Last modified: 2014-06-02 11:36:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67772, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65772 - update.php: Time taken is incorrect when the upgrade takes 1 hour or more
update.php: Time taken is incorrect when the upgrade takes 1 hour or more
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.24rc
All All
: Low trivial (vote)
: ---
Assigned To: Kevin Israel (PleaseStand)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-26 14:58 UTC by Kevin Israel (PleaseStand)
Modified: 2014-06-02 11:36 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kevin Israel (PleaseStand) 2014-05-26 14:58:23 UTC 
I was looking back at a change I reviewed and realized that a subsequent patch set (commit fae8daa658c1) does not correctly report durations of 1 hour or more. For example, if the upgrade takes 4567 seconds (1 hour 16 minutes 7 seconds), the "Done in [...]" message would include:

> var_dump((new MWTimestamp)->diff(new MWTimestamp(time()-4567))->format('%i:%S'));
string(5) "16:07"
Comment 1 Gerrit Notification Bot 2014-05-26 15:03:13 UTC 
Change 135433 had a related patch set uploaded by PleaseStand:
update.php: Correctly report durations >= 1 hour

https://gerrit.wikimedia.org/r/135433
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links