Last modified: 2014-05-28 04:14:28 UTC
Created attachment 15480 [details] Screenshot of the invite by reporter The signup invites (<https://www.mediawiki.org/wiki/Anonymous_editor_acquisition/Signup_invites>) trap the ctrl-click or middle-click or whatever. Reported yesterday on #wikimedia but still not filed AFAICS. 06.12 < mr-chen-> [ISSUE] middle clicking no longer works for unregistered users wishing to edit a page 06.46 < mr-chen-> the dialogue box messes up middle clicking the "Edit" link to open in a new tab
I just tested this in the pre-edit tour and middle click works just fine.
Created attachment 15482 [details] Middle click
I can't test this bug because I don't know how to trigger the invite, but your screenshot shows a left click, not a middle click.
Confirmed on it.wiki (Chrome 35.0.1916.114). 1) [[it:Special:Random]] as unregistered user (non-incognito mode) I. Observed: I see "edit" and "edit source" tabs. 2) Ctrl-click or middle-click any of the two. II. Observed: the invite popup appears. (If it doesn't, return to 1.) III. Expected: action=edit or veaction=edit URL is opened in a new tab. 3) Ctrl-click or middle-click any of the two. IV. Observed: the invite stays, but the URL is correctly opened in a new tab.
I think i'm to silly for this :D I logged out of wikipedia and clear all cookies. After this i opened [[it:Special:Random]]. Now i can click on edit or edit source and the popup, that i can register appears, so long, so good :) I can middle click and the popup stands (correctly) and the edit page opens in new tab. If i start from one, i can middle click on the edit source and edit button and no popup appears, but the edit page opens in new tab. So, with Firefox ESR 17.0.1 all is ok, or not? :)
True, the behaviour in Firefox (29.0.1) is different: for me, II. Observed: No popup appears, the tab is correctly opened in a new tab.
Sorry, I mean that I know the popup should have appeared because it did when I left-clicked the button right after middle-clicking it.
Confirmed the behaviour in Google Chrome (35.0.1916.114) and Firefox (29.0.1).
This is caused by the following line: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted.git/4d50dae685c05c1dfcc463ef1992e0b7056267d4/resources%2Fext.gettingstarted.anonymousEditorAcquisition.js#L135.
Note well that after you click then link and see the popup the link should behave as expected.
First, I should note that this is no longer active on the production cluster, because the initial experiment is over. Thus, it can not currently be tested on Italian Wikipedia, etc. However, if we do re-enable this in some form, it's important to know what you're testing. When it was running, this was exposed with: mw.gettingStarted.user.getBucket() Also, there is a localStorage field that marks whether you're already seen the dialog. For some people this didn't work, but for others it may have. I think I get the same behavior as Nemo in #6, if I understand what he saw, also in Firefox/Iceweasel 29.0.1. Middle-clicking opens a new tab and ignores the click handler. So then the question is what behavior we actually want. * Should it still show the popup despite them middle-clicking (rather than left-clicking)? (Is this possible cross-browser without removing the href entirely?) * Or should it behave like Firefox 29, and just ignore the pre-edit in that case? (In reply to Nemo from comment #3) > I can't test this bug because I don't know how to trigger the invite, but > your screenshot shows a left click, not a middle click. Steven's screenshot is showing the context menu. So that's also indication it's not a left click (by "left click" we mean primary click). Steven, can you clarify the sequence? Did you middle click first? Or did you left click to open the dialog, then middle click when it was already open? I've set the priority back to Normal, and the component to the extension where the code is.
