Last modified: 2014-06-16 23:55:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67816, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65816 - References drawer doesn't work after editing
References drawer doesn't work after editing
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-27 16:38 UTC by Juliusz Gonera
Modified: 2014-06-16 23:55 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Juliusz Gonera 2014-05-27 16:38:33 UTC 
Edit a page with references, click on a reference after saving your edit.

Expected: see reference drawer
Result: #cite_note-1 appended in the URL, nothing happens
Comment 1 Bingle 2014-05-27 16:40:14 UTC 
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/P8B6FH4m
Comment 2 Florian 2014-05-28 11:41:09 UTC 
In bet mode the references are handeled by mf-toggle-dynamic (https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/b94649e6ae9d0a3d02c002873ac29046cb1f1dc2/javascripts/modules/mf-toggle-dynamic.js). I'm don't know, how the roadmap is, but maybe we can wait, until mf-toggle-dynamic is enabled in stable?
Comment 3 Jon 2014-05-28 16:26:54 UTC 
References appear to be enabled only when the events section-rendered or references-loaded events are run.

I suspect these are not being run.

@Juliusz what are your thoughts on the toggle-dynamic code? Basically it just defers loading of images inside sections.

We could either kill it outright to simplify things or we should push it to stable (I am leaning towards killing the code for the time being since it was written with the pretense we would be loading all sections on mobile via JavaScript and only serving the lead section in the HTML).
Comment 4 Florian 2014-05-31 00:22:16 UTC 
Can be patch to review, right? :)
https://gerrit.wikimedia.org/r/#/c/136489/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links