Last modified: 2014-05-30 18:29:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67862, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65862 - VisualEditor: If the TemplateData description for a parameter is just whitespace, then hide the help/information button
VisualEditor: If the TemplateData description for a parameter is just whites...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-06-05
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-28 17:26 UTC by WhatamIdoing
Modified: 2014-05-30 18:29 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-05-28 17:26:21 UTC
If the "description" field for TemplateData is empty, clicking the help/information button (an i with a circle around it) for the parameter produces a very skinny, empty box.  Nothing should be displayed when there is no description to display.

Alternatively, it's possible that some standard text could be put in the box, like "There is no description for this item".
Comment 1 James Forrester 2014-05-29 19:43:50 UTC
I thought we had disabled these, but apparently not. Bah.
Comment 2 Alex Monk 2014-05-30 12:44:29 UTC
If the parameter is required, I do get 'Field is required.' which should be shown still. But if it's not required, then the help/information button is disabled... No empty box.
Comment 3 Alex Monk 2014-05-30 12:46:01 UTC
WhatamIdoing, can you perhaps give an example page where it does this?
Comment 4 WhatamIdoing 2014-05-30 15:08:59 UTC
Open the infobox in https://en.wikipedia.org/wiki/Aberystwyth and look at the parameter "os_grid_reference".

The original report is at https://en.wikipedia.org/w/index.php?oldid=610519258#Info_on_template_fields
Comment 5 Alex Monk 2014-05-30 15:12:39 UTC
The description is set as a single space for this parameter, so I think this is expected behaviour.
Comment 6 WhatamIdoing 2014-05-30 17:07:02 UTC
Ah:  the TemplateData at https://en.wikipedia.org/wiki/Template:Infobox_UK_place/doc#TemplateData says,


"os_grid_reference": { "label": "os grid reference", "description": " ", "type": "string", "required": false },


If it said this instead,

"os_grid_reference": { "label": "os grid reference", "description": "", "type": "string", "required": false },

or perhaps this:

"os_grid_reference": { "label": "os grid reference", "type": "string", "required": false },

(if it's permitted to omit the description item), then this should go away.
Comment 7 Gerrit Notification Bot 2014-05-30 17:20:35 UTC
Change 136348 had a related patch set uploaded by Alex Monk:
Trim description when working out whether or not we should disable the info button

https://gerrit.wikimedia.org/r/136348
Comment 8 James Forrester 2014-05-30 17:41:27 UTC
Thanks!
Comment 9 Gerrit Notification Bot 2014-05-30 18:29:20 UTC
Change 136348 merged by jenkins-bot:
Trim description when working out whether or not we should disable the info button

https://gerrit.wikimedia.org/r/136348

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links