Last modified: 2014-11-13 18:17:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67879, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65879 - Unit tests fail if Site is named 'Foo'
Unit tests fail if Site is named 'Foo'
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.24rc
All All
: Low minor (vote)
: ---
Assigned To: Umherirrender
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-28 22:29 UTC by Jeff Janes
Modified: 2014-11-13 18:17 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jeff Janes 2014-05-28 22:29:48 UTC 
If you name your wiki site 'Foo', as I usually did when making a wiki for testing purposes, the unit tests fail.

It fails because tests/phpunit/includes/TitleTest.php uses 'Talk:Foo:Sandbox' to construct a title to be tested and found valid, and apparently this not valid if the wiki site has been named Foo.

Is there any good defense against this?  Should I just add a note saying "don't do that" to https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Running_the_unit_tests ?
Comment 1 Gerrit Notification Bot 2014-11-13 18:17:10 UTC 
Change 173060 had a related patch set uploaded by Umherirrender:
Set wgMetaNamespace on TitleTest.php

https://gerrit.wikimedia.org/r/173060
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links