Last modified: 2014-06-12 00:32:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67915, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65915 - Flow: Interwiki exceptions from Special:WhatLinksHere
Flow: Interwiki exceptions from Special:WhatLinksHere
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized major (vote)
: ---
Assigned To: Andrew Garrett
https://en.wikipedia.org/wiki/Special...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-29 21:47 UTC by spage
Modified: 2014-06-12 00:32 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-05-29 21:47:06 UTC
It seems asking for WhatLinkshere on one wiki causes exceptions when there are links to it on another wiki.

Happens on enwiki for File:OUYA-Console-set-h.jpg, which I linked on mw.org, also on enwiki for Talk:Sandbox, Template:Bug, etc. But this doesn't happen on meta-wiki which is running the same version, or on mw.org.  Confusing.

Perhaps the Flow hook that tries to create a link on WhatLinksHereProp needs to be more robust. Or maybe we need to run maintenance/FlowPopulateLinksTables.php against multiple wikis.

Here's one:

2014-05-29 17:52:55 mw1076 enwiki: [12257f85] /wiki/Special:WhatLinksHere/File:OUYA-Console-set-h.jpg   Exception from line 182 of /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/includes/Model/Workflow.php: Interwiki to mediawikiwiki not implemented 
#0 /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/includes/BaseUrlGenerator.php(171): Flow\Model\Workflow->getArticleTitle()
#1 /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/includes/UrlGenerator.php(202): Flow\BaseUrlGenerator->resolveTitle(NULL, Object(Flow\Model\UUID))
#2 /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/includes/ReferenceClarifier.php(50): Flow\UrlGenerator->postLink(NULL, Object(Flow\Model\UUID), Object(Flow\Model\UUID))
#3 /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/includes/ReferenceClarifier.php(28): Flow\ReferenceClarifier->getObjectLink(Object(Flow\Model\UUID), 'post', Object(Flow\Model\UUID))
#4 /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/Hooks.php(620): Flow\ReferenceClarifier->getWhatLinksHereProps(Object(stdClass), Object(Title), Object(Title))
#5 [internal function]: FlowHooks::onWhatLinksHereProps(Object(stdClass), Object(Title), Object(Title), Array)
#6 /usr/local/apache/common-local/php-1.24wmf5/includes/Hooks.php(206): call_user_func_array('FlowHooks::onWh...', Array)
#7 /usr/local/apache/common-local/php-1.24wmf5/includes/GlobalFunctions.php(4004): Hooks::run('WhatLinksHerePr...', Array, NULL)
#8 /usr/local/apache/common-local/php-1.24wmf5/includes/specials/SpecialWhatlinkshere.php(329): wfRunHooks('WhatLinksHerePr...', Array)
#9 /usr/local/apache/common-local/php-1.24wmf5/includes/specials/SpecialWhatlinkshere.php(272): SpecialWhatLinksHere->listItem(Object(stdClass), Object(Title), Object(Title))
Comment 1 bsitu 2014-05-29 23:08:16 UTC
It seems that we are loading links by namespace/title pair.  If a page with the same namespace/title exists in multitple wikis, this would load unwanted data from other wikis.  I think this could be resolved in two steps:

1. Catch the exception and ignore unrelated reference

2. Add a wiki field to flow_wiki_ref so only to load reference for the page in current wiki, remove the exception in step 1.
Comment 2 Gerrit Notification Bot 2014-05-29 23:39:00 UTC
Change 136256 had a related patch set uploaded by Bsitu:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136256
Comment 3 Andrew Garrett 2014-05-30 04:35:57 UTC
*** Bug 65802 has been marked as a duplicate of this bug. ***
Comment 4 Gerrit Notification Bot 2014-05-30 05:08:30 UTC
Change 136280 had a related patch set uploaded by Werdna:
Segregate Reference objects by source wiki.

https://gerrit.wikimedia.org/r/136280
Comment 5 Andre Klapper 2014-05-30 06:52:31 UTC
*** Bug 65802 has been marked as a duplicate of this bug. ***
Comment 6 Gerrit Notification Bot 2014-06-02 09:55:26 UTC
Change 136256 merged by jenkins-bot:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136256
Comment 7 Gerrit Notification Bot 2014-06-02 22:38:23 UTC
Change 136932 had a related patch set uploaded by Spage:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136932
Comment 8 Gerrit Notification Bot 2014-06-02 22:39:36 UTC
Change 136932 merged by jenkins-bot:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136932
Comment 9 Gerrit Notification Bot 2014-06-02 22:40:45 UTC
Change 136933 had a related patch set uploaded by Spage:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136933
Comment 10 Gerrit Notification Bot 2014-06-02 22:45:25 UTC
Change 136933 merged by jenkins-bot:
Ignore expected exceptions in WhatLinksHere

https://gerrit.wikimedia.org/r/136933
Comment 11 spage 2014-06-12 00:32:42 UTC
We're no longer getting these. We're getting Flow Interwiki exceptions from certain Special:Contributions

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links