Last modified: 2014-06-03 05:28:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67922, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65922 - simple_performant fails to provision with Apache-related error
simple_performant fails to provision with Apache-related error
Status: RESOLVED FIXED
Product: MediaWiki-Vagrant
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-29 23:21 UTC by Matthew Flaschen
Modified: 2014-06-03 05:28 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Puppet log (1.21 KB, text/plain)
2014-05-29 23:21 UTC, Matthew Flaschen
Details
Roles enabled when provisioning fails (2.19 KB, text/plain)
2014-05-29 23:22 UTC, Matthew Flaschen
Details

Description Matthew Flaschen 2014-05-29 23:21:54 UTC
Created attachment 15525 [details]
Puppet log

For completeness, I'll post a few things, including the full error and what roles I have enabled.  Short version is:

You cannot specify more than one of content, source, target at /tmp/vagrant-puppet-3/modules-0/apache/manifests/conf.pp:59

What's weird is that seems to be old code from https://gerrit.wikimedia.org/r/#/c/78401/ , but the provisioning error only occurs if simple_performant is enabled.
Comment 1 Matthew Flaschen 2014-05-29 23:22:57 UTC
Created attachment 15526 [details]
Roles enabled when provisioning fails
Comment 2 Nemo 2014-06-02 20:50:05 UTC
I'd go for the silliest suspects first: like, let's change the name of either:

apache::mod { 'expires': }
[...]
apache::conf { 'expires':
Comment 3 Nemo 2014-06-02 21:00:25 UTC
Nope, wishful thinking didn't help, that's not it; I get the error anyway on labs-vagrant.
Comment 4 Nemo 2014-06-02 22:05:06 UTC
Well we do have two apache::conf as no other role:

    include role::thumb_on_404

hence

    apache::conf { 'thumb.php on 404':
...

+

    apache::conf { 'expires':
...

which then go to

    $config_file = inline_template('<%= @title.gsub(/\W/, "-") %>')

    file { "${config_dir}/${config_file}${config_extension}":

Do we just have to make ${config_file} different for the two?
Comment 5 Matthew Flaschen 2014-06-03 00:44:19 UTC
No, that's not a problem, since the filename is auto-generated form the title (e.g. 'expires' is one of the titles here).

Actually, the error text is accurate.  The problem is two-fold:

1. It's referring to a non-existent 'puppet:///files/expires' file (this file was not added with the commit).
2. Either content (text to put in the file) or source (filename to copy to file) is needed, not both.  Content is already there.

I'm testing the fix right now (it's taking a little while on the localization rebuild), but it's gotten much farther than before.
Comment 6 Gerrit Notification Bot 2014-06-03 00:56:10 UTC
Change 136961 had a related patch set uploaded by Mattflaschen:
Remove unneeded source attribute (content used instead)

https://gerrit.wikimedia.org/r/136961
Comment 7 Matthew Flaschen 2014-06-03 01:12:09 UTC
Works fine, although I found bug 66061.
Comment 8 Gerrit Notification Bot 2014-06-03 04:59:52 UTC
Change 136961 merged by jenkins-bot:
Remove unneeded source attribute (content used instead)

https://gerrit.wikimedia.org/r/136961

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links