Last modified: 2014-06-20 14:52:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67923, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65923 - Popups mwe-popups-animation() duplicates core .animation() mixin
Popups mwe-popups-animation() duplicates core .animation() mixin
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Popups (Other open bugs)
master
All All
: Unprioritized minor (vote)
: ---
Assigned To: Prateek Saxena
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-29 23:25 UTC by spage
Modified: 2014-06-20 14:52 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-05-29 23:25:16 UTC
.mwe-popups-animation() in ext.popups.animation.less calls the four prefix variants of {-webkit-,-moz-,-o-,}animation. There's already a mixin function for this in mediawiki.less , so those four lines could be replaced by

@import "mediawiki.mixins.animation"
...
.mwe-popups-animation(...) {
    .animation(@arguments);
...
...
}

Maybe also add a comment

/* TODO move animation-fill-mode and transform convenience functions into mediawiki.less/mediawiki.mixins.animation in core. */
Comment 1 Gerrit Notification Bot 2014-06-03 06:27:08 UTC
Change 136975 had a related patch set uploaded by Prtksxna:
animation: Use the animation mixin in core and pass fill-mode as an argument

https://gerrit.wikimedia.org/r/136975
Comment 2 Gerrit Notification Bot 2014-06-06 11:10:26 UTC
Change 136975 merged by jenkins-bot:
animation: Use the animation mixin in core and pass fill-mode as an argument

https://gerrit.wikimedia.org/r/136975

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links