Last modified: 2014-11-03 20:19:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67928, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 65928 - VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article
VisualEditor: Clicking on Edit link beside a section heading does not take us...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-06-19
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-30 01:13 UTC by Rummana Yasmeen
Modified: 2014-11-03 20:19 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rummana Yasmeen 2014-05-30 01:13:26 UTC
Steps to reproduce:

1.Click on the Edit/Edit Beta link beside a section heading of an article

Observed Result:
It places the cursor at the beginning of the document .
Comment 1 Roan Kattouw 2014-06-05 21:12:52 UTC
It seems like the dm.Surface's selection is getting set to the beginning of the section like it should be, but then when the ce/ui.Surface is intialized, the cursor isn't put there. It seems the surface isn't focused correctly on init anyway, and as soon as you interact with it SurfaceObserver will notice the cursor is at (1,1) and change the DM selection to that.
Comment 2 Gerrit Notification Bot 2014-06-15 11:57:53 UTC
Change 139677 had a related patch set uploaded by Esanders:
Wait for onDocumentFocus to happen before setting section range

https://gerrit.wikimedia.org/r/139677
Comment 3 Gerrit Notification Bot 2014-06-15 12:39:57 UTC
Change 139677 merged by jenkins-bot:
Wait for onDocumentFocus to happen before setting section range

https://gerrit.wikimedia.org/r/139677
Comment 4 Rummana Yasmeen 2014-06-17 22:22:36 UTC
Verified the fix in Betalabs
Comment 5 Rummana Yasmeen 2014-06-20 22:59:26 UTC
Not fixed for Firefox , there is no cursor at all pointing anywhere in the document after clicking on Edit link for section editing.
Comment 6 Ed Sanders 2014-06-24 14:27:08 UTC
WFM in Firefox at http://en.wikipedia.beta.wmflabs.org/wiki/WikiNodes and on master
Comment 7 James Forrester 2014-06-24 15:02:41 UTC
Probably a deployment issue; fixed on MW.org and test2.
Comment 8 Rummana Yasmeen 2014-06-25 19:15:09 UTC
This is still happening on FireFox in Betalabs running from master.
Comment 9 James Forrester 2014-06-25 20:04:16 UTC
WFM; cache issue, it appears.
Comment 10 Rummana Yasmeen 2014-06-27 18:07:07 UTC
Verified the fix in production. There is a different issue with cursor now though 
which has been reported in:
https://bugzilla.wikimedia.org/show_bug.cgi?id=67106
Comment 11 Tony Thomas 2014-11-03 17:32:56 UTC
This still happens. Check https://www.mediawiki.org/w/index.php?title=WYSIWYG_editor&veaction=edit&vesection=18 from chrome !
Comment 12 James Forrester 2014-11-03 20:19:16 UTC
(In reply to Tony Thomas from comment #11)
> This still happens. Check
> https://www.mediawiki.org/w/index.
> php?title=WYSIWYG_editor&veaction=edit&vesection=18 from chrome !

Eugh, there seems to be a regression here when clicked on the page; if you click that link it works fine… As such, rather than re-opening I've created bug 72919 for this. Thanks for the spot.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links