Last modified: 2014-08-14 20:47:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68053, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66053 - [scap] Sync fewer files from old deploy branches
[scap] Sync fewer files from old deploy branches
Status: NEW
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-02 21:46 UTC by Bryan Davis
Modified: 2014-08-14 20:47 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bryan Davis 2014-06-02 21:46:33 UTC
We keep multiple older php-1.XwmfY branches checked out in /a/common to support static assets that may be referenced by pages in the Varnish cache. The sheer number of files contained in these branches causes a non-trivial additional time cost for each scap sync.

Since we are only keeping these branches around to support static asset delivery, it seems possible to add a cleanup step to the train deploys to prune the files in the inactive branches that are only needed for active runtime. This is primarily the php files but could also include javascript, json, sql, all tests and possibly additional file types.

Here's a quick comparison:

tin:/a/common/php-1.23wmf21  (git wmf/1.23wmf21)
bd808$ find . -type d -name .git -prune -o -type f -print|wc -l
35775

tin:/a/common/php-1.23wmf21  (git wmf/1.23wmf21)
bd808$ find . -type d -name .git -prune -name tests -prune -o -type f -not -name '*.php' -not -name '*.json' -not -name '*.js' -not -name '*.sql' -print|wc -l
6326

In this case getting rid of php, json, js, sql and tests would reduce the number of files compared for a sync by almost 30,000 (~80%).
Comment 1 Bryan Davis 2014-06-02 21:54:21 UTC
With the new functionality in sync-common where --include=<directory> can be passed to the leaf hosts to modify the files/directories that are being asked for synchronization. Scap could use it's knowledge of active branches to exclude php-1.XwmfY branches from syncing that are not actively in use on the cluster. Doing this would probably need to also include of branches that are newer than active (eg the branch that *will* be live on the group0 hosts soon).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links