Last modified: 2014-08-20 21:36:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68060, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66060 - Flow: mediawiki notification exceptions: "Argument 1 passed to Flow\UrlGenerator::workflowLink() must be an instance of Title", UUID instead
Flow: mediawiki notification exceptions: "Argument 1 passed to Flow\UrlGenera...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-03 00:22 UTC by spage
Modified: 2014-08-20 21:36 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-06-03 00:22:04 UTC
exception.log in production has a steady stream of these. All on mediawikiwiki, either from Special:Notifications.  103 of them, starting May 11.

These seem to be notifications for the current user, so you don't get them if you visit this URL yourself.  It's unclear what user is getting these errors. The failure is coming from

extensions/Echo/formatters/BasicFormatter.php(647): Flow\NotificationFormatter->processParam(Object(EchoEvent), 'topic-permalink', Object(Message), Object(User))


2014-06-03 00:04:12 mw1191 mediawikiwiki: [36f37e94] /w/api.php?action=query&format=json&meta=notifications&notformat=flyout&notlimit=8&notprop=index%7Clist%7Ccount&_=1401753850252   Exception from line 357 of /usr/local/apache/common-local/php-1.24wmf7/extensions/Flow/includes/UrlGenerator.php: Catchable fatal error: Argument 1 passed to Flow\UrlGenerator::workflowLink() must be an instance of Title, instance of Flow\Model\UUID given, called in /usr/local/apache/common-local/php-1.24wmf7/extensions/Flow/includes/Notifications/Formatter.php on line 54

and

[f5218bdd] /wiki/Special:Notifications   Exception from line 343 of /usr/local/apache/common-local/php-1.24wmf6/extensions/Flow/includes/UrlGenerator.php: Catchable fatal error: Argument 1 passed to Flow\UrlGenerator::workflowLink() must be an instance of Title, instance of Flow\Model\UUID given, called in /usr/local/apache/common-local/php-1.24wmf6/extensions/Flow/includes/Notifications/Formatter.php on line 54 and defined


full trace of most recent:

2014-06-03 00:04:12 mw1191 mediawikiwiki: [36f37e94] /w/api.php?action=query&format=json&meta=notifications&notformat=f
lyout&notlimit=8&notprop=index%7Clist%7Ccount&_=1401753850252   Exception from line 357 of /usr/local/apache/common-loc
al/php-1.24wmf7/extensions/Flow/includes/UrlGenerator.php: Catchable fatal error: Argument 1 passed to Flow\UrlGenerato
r::workflowLink() must be an instance of Title, instance of Flow\Model\UUID given, called in /usr/local/apache/common-l
ocal/php-1.24wmf7/extensions/Flow/includes/Notifications/Formatter.php on line 54 and defined
#0 /usr/local/apache/common-local/php-1.24wmf7/extensions/Flow/includes/UrlGenerator.php(357): EchoNotificationControll
er::formatterErrorHandler(4096, 'Argument 1 pass...', '/usr/local/apac...', 357, Array)
#1 /usr/local/apache/common-local/php-1.24wmf7/extensions/Flow/includes/Notifications/Formatter.php(54): Flow\UrlGenera
tor->workflowLink(Object(Flow\Model\UUID))
#2 /usr/local/apache/common-local/php-1.24wmf7/extensions/Echo/formatters/BasicFormatter.php(647): Flow\NotificationFormatter->processParam(Object(EchoEvent), 'topic-permalink', Object(Message), Object(User))
#3 /usr/local/apache/common-local/php-1.24wmf7/extensions/Echo/formatters/BasicFormatter.php(361): EchoBasicFormatter->processParams(Array, Object(EchoEvent), Object(Message), Object(User))
#4 /usr/local/apache/common-local/php-1.24wmf7/extensions/Echo/formatters/BasicFormatter.php(260): EchoBasicFormatter->formatFragment(Array, Object(EchoEvent), Object(User))
#5 /usr/local/apache/common-local/php-1.24wmf7/extensions/Echo/formatters/BasicFormatter.php(222): EchoBasicFormatter->formatNotificationTitle(Object(EchoEvent), Object(User))
#6 /usr/local/apache/common-local/php-1.24wmf7/extensions/Echo/controller/NotificationController.php(338): EchoBasicFormatter->format(Object(EchoEvent), Object(User), 'web')
#7 /usr/local/apache/common-local/php-1.24wmf7/extensions/Echo/api/ApiEchoNotifications.php(144): EchoNotificationController::formatNotification(Object(EchoEvent), Object(User), 'flyout')
#8 /usr/local/apache/common-local/php-1.24wmf7/extensions/Echo/api/ApiEchoNotifications.php(26): ApiEchoNotifications::getNotifications(Object(User), 'flyout', 9, NULL)
#9 /usr/local/apache/common-local/php-1.24wmf7/includes/api/ApiQuery.php(282): ApiEchoNotifications->execute()

and

2014-05-29 18:36:08 mw1213 mediawikiwiki: [f5218bdd] /wiki/Special:Notifications   Exception from line 343 of /usr/loca
l/apache/common-local/php-1.24wmf6/extensions/Flow/includes/UrlGenerator.php: Catchable fatal error: Argument 1 passed 
to Flow\UrlGenerator::workflowLink() must be an instance of Title, instance of Flow\Model\UUID given, called in /usr/lo
cal/apache/common-local/php-1.24wmf6/extensions/Flow/includes/Notifications/Formatter.php on line 54 and defined
#0 /usr/local/apache/common-local/php-1.24wmf6/extensions/Flow/includes/UrlGenerator.php(343): EchoNotificationControll
er::formatterErrorHandler(4096, 'Argument 1 pass...', '/usr/local/apac...', 343, Array)
#1 /usr/local/apache/common-local/php-1.24wmf6/extensions/Flow/includes/Notifications/Formatter.php(54): Flow\UrlGenera
tor->workflowLink(Object(Flow\Model\UUID))
#2 /usr/local/apache/common-local/php-1.24wmf6/extensions/Echo/formatters/BasicFormatter.php(647): Flow\NotificationFor
matter->processParam(Object(EchoEvent), 'topic-permalink', Object(Message), Object(User))
#3 /usr/local/apache/common-local/php-1.24wmf6/extensions/Echo/formatters/BasicFormatter.php(361): EchoBasicFormatter->
processParams(Array, Object(EchoEvent), Object(Message), Object(User))
#4 /usr/local/apache/common-local/php-1.24wmf6/extensions/Echo/formatters/BasicFormatter.php(262): EchoBasicFormatter->
formatFragment(Array, Object(EchoEvent), Object(User))
#5 /usr/local/apache/common-local/php-1.24wmf6/extensions/Echo/formatters/BasicFormatter.php(222): EchoBasicFormatter->
formatNotificationTitle(Object(EchoEvent), Object(User))
#6 /usr/local/apache/common-local/php-1.24wmf6/extensions/Echo/controller/NotificationController.php(338): EchoBasicFor
matter->format(Object(EchoEvent), Object(User), 'web')
#7 /usr/local/apache/common-local/php-1.24wmf6/extensions/Echo/api/ApiEchoNotifications.php(144): EchoNotificationContr
oller::formatNotification(Object(EchoEvent), Object(User), 'html')
#8 /usr/local/apache/common-local/php-1.24wmf6/extensions/Echo/special/SpecialNotifications.php(41): ApiEchoNotificatio
ns::getNotifications(Object(User), 'html', 21, NULL)
#9 /usr/local/apache/common-local/php-1.24wmf6/includes/specialpage/SpecialPage.php(379): SpecialNotifications->execute
(NULL)
Comment 1 Gerrit Notification Bot 2014-06-03 00:45:01 UTC
Change 136958 had a related patch set uploaded by Bsitu:
Flow: notification exceptions: urlGenerator->workflowLink()

https://gerrit.wikimedia.org/r/136958
Comment 2 Gerrit Notification Bot 2014-06-03 23:24:50 UTC
Change 136958 merged by jenkins-bot:
Flow: notification exceptions: urlGenerator->workflowLink()

https://gerrit.wikimedia.org/r/136958
Comment 3 Andre Klapper 2014-08-17 11:26:19 UTC
All patches mentioned in this report are merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links