Last modified: 2014-06-04 04:08:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68082, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66082 - Drop *_user_text fields in Flow
Drop *_user_text fields in Flow
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Sean Pringle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-03 17:58 UTC by Erik Bernhardson
Modified: 2014-06-04 04:08 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erik Bernhardson 2014-06-03 17:58:49 UTC
Short description:

When we moved *_user_text stuff to *_user_ip, we never actually
got rid of *_user_text columns in the DB.
These columns still exist, though they shouldn't. Especially
flow_workflow.workflow_user_text, which is NOT NULL, but is now
always fed null values.
It seems that production etc. is tolerant and still lets our
inserts in, but we should definitely get rid of those columns.

Which wikis are affected:

flowdb on extension1db

Which tables:

flow_workflow, flow_tree_revision, flow_revision

What is the change to those tables:

ALTER TABLE /*_*/flow_workflow DROP workflow_user_text;

ALTER TABLE /*_*/flow_tree_revision DROP tree_orig_user_text;

ALTER TABLE /*_*/flow_revision
       DROP rev_user_text,
       DROP rev_mod_user_text,
       DROP rev_edit_user_text;

Links to gerrit changes and/or other related bug reports.

https://gerrit.wikimedia.org/r/#/c/135576/3
Comment 1 Sean Pringle 2014-06-04 04:08:19 UTC
Done.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links