Last modified: 2014-06-13 19:38:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68105, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66105 - VisualEditor: If you have added a category already, typing it in a second time doesn't show it in the list — except if the category is a "red link", in which case it will suggest it as a new one again
VisualEditor: If you have added a category already, typing it in a second tim...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-06-05
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-04 00:08 UTC by Rummana Yasmeen
Modified: 2014-06-13 19:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (49.20 KB, image/png)
2014-06-04 00:08 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-06-04 00:08:29 UTC 
Created attachment 15561 [details]
Screenshot

Steps to reproduce:


1.Open VE
2.Go to Page options>Categories
3.Insert a new category:Ca, it appears under matching categories section according to the change on https://bugzilla.wikimedia.org/show_bug.cgi?id=49044
4.Select the first match Ca
4.Now again type Ca

Observed Result:
This time it appears under New Category section.


see the screenshot attached
Comment 1 Gerrit Notification Bot 2014-06-04 13:53:05 UTC 
Change 137307 had a related patch set uploaded by Alex Monk:
Check last existing category for whether or not we're trying to re-add it

https://gerrit.wikimedia.org/r/137307
Comment 2 Gerrit Notification Bot 2014-06-04 22:10:23 UTC 
Change 137307 merged by jenkins-bot:
Check last existing category for whether or not we're trying to re-add it

https://gerrit.wikimedia.org/r/137307
Comment 3 Alex Monk 2014-06-04 22:14:08 UTC 
Fixed. That function is full of horrible things to do with following redirects (where a supposed category is actually a redirect to another category) and categories which are marked as hidden, mostly my fault and probably full of bugs if you want to poke around with that. Particularly in cases where we're supposed to exclude suggestions due to already having the suggestion on the list.
Comment 4 Rummana Yasmeen 2014-06-13 19:38:10 UTC 
Verified the fix in en.wiki running wmf 8
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links