Last modified: 2014-06-07 01:01:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68135, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66135 - VisualEditor: Link inspector should not send invalid titles to the API for suggestions (because it won't be valuable)
VisualEditor: Link inspector should not send invalid titles to the API for su...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-06-12
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-04 19:52 UTC by Gabriel Wicke
Modified: 2014-06-07 01:01 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Gabriel Wicke 2014-06-04 19:52:59 UTC
Browser: Chromium 35.0.1916.114 Debian Linux
Comment 2 Gabriel Wicke 2014-06-04 20:13:49 UTC
This shows up in the JS console:

Failed to load resource: the server responded with a status of 400 (Bad Request) https://www.mediawiki.org/w/api.php?format=json&action=query&generator=pref…edian&gpsnamespace=0&prop=info%7Cpageprops&ppprop=disambiguation&redirect=
Comment 3 James Forrester 2014-06-04 20:43:10 UTC
This is two separate bugs – we shouldn't be sending these to the API anyway, but we also should cope with the 400 error, which I've made into bug 66139.
Comment 4 Alex Monk 2014-06-05 23:45:42 UTC
I can replicate this on mediawiki.org but not en.wikipedia.org or my local dev wiki.
Comment 5 Alex Monk 2014-06-06 18:52:16 UTC
The HTTP 400 error we get comes with an error: {"code":"request_too_long","info":"Prefix search request was longer longer than the maximum allowed length. (267 > 255)"}

This is sent by CirrusSearch. Which explains why some wikis don't have this issue.
Comment 6 Alex Monk 2014-06-06 19:12:31 UTC
External URLs can be valid titles, we just want to ignore invalid titles (i.e. things over 255 characters).
Comment 7 Gerrit Notification Bot 2014-06-06 20:05:03 UTC
Change 138016 had a related patch set uploaded by Alex Monk:
Don't sent invalid titles from the link inspector to the API

https://gerrit.wikimedia.org/r/138016
Comment 8 Gerrit Notification Bot 2014-06-07 01:01:51 UTC
Change 138016 merged by jenkins-bot:
Don't send invalid titles from the link inspector to the API

https://gerrit.wikimedia.org/r/138016

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links