Last modified: 2014-06-05 21:02:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68141, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66141 - Fatal error when previewing a template that doesn't yet exist
Fatal error when previewing a template that doesn't yet exist
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TemplateSandbox (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Adam Wight
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-04 21:42 UTC by Jackmcbarn
Modified: 2014-06-05 21:02 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jackmcbarn 2014-06-04 21:42:42 UTC 
On the beta cluster, the page "User:Jackmcbarn/Page" contains "{{A nonexistent template}}" as the content. If you go to http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Template:A_nonexistent_template&action=edit and enter "User:Jackmcbarn/Page" in the page title box, a fatal error will be generated when previewing: PHP fatal error in /srv/common-local/php-master/extensions/TemplateSandbox/TemplateSandbox.hooks.php line 205:
Call to a member function isRedirect() on a non-object
Comment 1 Jackmcbarn 2014-06-04 21:53:41 UTC 
This appears to have been caused by I83cdd4adaaa67f81e933654228eccdc9fcdf9009 in core.
Comment 2 Gerrit Notification Bot 2014-06-05 00:35:41 UTC 
Change 137511 had a related patch set uploaded by Awight:
(bug 66141) Allow replaceSection on an unborn page

https://gerrit.wikimedia.org/r/137511
Comment 3 Gerrit Notification Bot 2014-06-05 14:23:13 UTC 
Change 137641 had a related patch set uploaded by Anomie:
Properly handle preview when creating a template

https://gerrit.wikimedia.org/r/137641
Comment 4 Brad Jorsch 2014-06-05 14:24:56 UTC 
While I83cdd4ad appears to have made the issue occur more often, the bug is still present before that change if you supply a section parameter when editing the nonexistent template.
Comment 5 Gerrit Notification Bot 2014-06-05 14:40:54 UTC 
Change 137641 merged by jenkins-bot:
Properly handle preview when creating a template

https://gerrit.wikimedia.org/r/137641
Comment 6 Gerrit Notification Bot 2014-06-05 14:48:16 UTC 
Change 137652 had a related patch set uploaded by Anomie:
Properly handle preview when creating a template

https://gerrit.wikimedia.org/r/137652
Comment 7 Gerrit Notification Bot 2014-06-05 14:48:43 UTC 
Change 137652 merged by jenkins-bot:
Properly handle preview when creating a template

https://gerrit.wikimedia.org/r/137652
Comment 8 Gerrit Notification Bot 2014-06-05 14:51:43 UTC 
Change 137653 had a related patch set uploaded by Anomie:
Update TemplateSandbox for bug 66141

https://gerrit.wikimedia.org/r/137653
Comment 9 Brad Jorsch 2014-06-05 14:55:14 UTC 
Fixed in TemplateSandbox, and will be included in 1.24wmf8.

That's not to say Awight's patch isn't necessary (I haven't looked closely), but not needed for this bug.
Comment 10 Gerrit Notification Bot 2014-06-05 15:16:51 UTC 
Change 137653 merged by Reedy:
Update TemplateSandbox for bug 66141

https://gerrit.wikimedia.org/r/137653
Comment 11 Gerrit Notification Bot 2014-06-05 20:31:20 UTC 
Change 137511 had a related patch set uploaded by TheDJ:
WikiPage: Allow replaceSection on an nonexistent page

https://gerrit.wikimedia.org/r/137511
Comment 12 Gerrit Notification Bot 2014-06-05 21:02:01 UTC 
Change 137511 merged by jenkins-bot:
WikiPage: Allow replaceSection on an nonexistent page

https://gerrit.wikimedia.org/r/137511
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links