Last modified: 2014-06-06 18:53:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68168, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66168 - VisualEditor: [Regression wmf7] Cursor is no longer getting automatically placed in the edit summary field; document isn't unfocussed in Firefox


Summary:	VisualEditor: [Regression wmf7] Cursor is no longer getting automatically pla...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	ContentEditable (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Highest major
Target Milestone:	VE-deploy-2014-06-12
Assigned To:	Ed Sanders

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-06-05 08:38 UTC by Amir E. Aharoni
Modified:	2014-06-06 18:53 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Amir E. Aharoni 2014-06-05 08:38:15 UTC

Note: This happens in mediawiki.org (1.24wmf7 (941d0e1)), but not in en.wikipedia (1.24wmf6 (4331f6b)).

To reproduce:
1. Edit an article. Make a change.
2. Press "Save page".
3. Try writing an edit summary.

Observed: The text is added to the article.

Expected: The cursor must automatically focus in the edit summary field.

Comment 1 James Forrester 2014-06-05 19:48:06 UTC

This is concerning; bug 65222 should have fixed this from happening. What browser were you using? I can't replicate in wmf7 in Chrome, Safari or Firefox.

However, it does seem to have regressed in wmf8.

Comment 2 Amir E. Aharoni 2014-06-05 20:32:01 UTC

I can still reproduce it in Firefox and Chrome on mediawiki.org.

In Firefox after opening the Save dialog, if I type, the text is added to the article.

In Chrome the text doesn't seem to be added anywhere.

And what's worse, I can now also reproduce it in the English Wikipedia.

Comment 3 James Forrester 2014-06-05 20:33:47 UTC

Sorry, that comment was half-written about a different bug. Bah Bugzilla.

I can indeed replicate in wmf7 and above (which is now everywhere).

Comment 4 Gerrit Notification Bot 2014-06-06 13:18:47 UTC

Change 137926 had a related patch set uploaded by Esanders:
Move save panel init to onReady

https://gerrit.wikimedia.org/r/137926

Comment 5 Gerrit Notification Bot 2014-06-06 18:44:06 UTC

Change 137971 had a related patch set uploaded by Jforrester:
Move save panel init to getReadyProcess

https://gerrit.wikimedia.org/r/137971

Comment 6 James Forrester 2014-06-06 18:44:29 UTC

Thanks Ed!

Comment 7 Gerrit Notification Bot 2014-06-06 18:53:50 UTC

Change 137926 merged by jenkins-bot:
Move save panel init to getReadyProcess

https://gerrit.wikimedia.org/r/137926

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links