Last modified: 2014-11-15 12:12:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68282, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66282 - Default image alignment is not applied to parsoid-output figure elements
Default image alignment is not applied to parsoid-output figure elements
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 66668 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-06 21:16 UTC by Ryan Kaldari
Modified: 2014-11-15 12:12 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Kaldari 2014-06-06 21:16:19 UTC 
If the alignment of an image is not explicitly set, Parsoid does not output an alignment class for the resultant figure element. This can lead to the image not being aligned/floated.

We need to modify content.parsoid.less to apply the default right-alignment styling to all images and then override this in cases where the alignment is explicitly set.
Comment 1 Gerrit Notification Bot 2014-06-06 21:18:39 UTC 
Change 138038 had a related patch set uploaded by Kaldari:
Make sure images that don't have an explicit alignment get aligned right

https://gerrit.wikimedia.org/r/138038
Comment 2 Gerrit Notification Bot 2014-06-06 23:21:35 UTC 
Change 138106 had a related patch set uploaded by Kaldari:
Make sure images are properly aligned in Mobile VisualEditor

https://gerrit.wikimedia.org/r/138106
Comment 3 Gerrit Notification Bot 2014-06-09 22:31:45 UTC 
Change 138106 merged by jenkins-bot:
Make sure images are properly aligned in Mobile VisualEditor

https://gerrit.wikimedia.org/r/138106
Comment 4 Gabriel Wicke 2014-06-16 15:54:58 UTC 
*** Bug 66668 has been marked as a duplicate of this bug. ***
Comment 5 Gabriel Wicke 2014-06-16 15:56:55 UTC 
Right now this is deployed to group 1 wikis, but not yet to group 2. Lets keep this open until it has made its way there.

Also see tracking bug 51245 for more Parsoid-specifc CSS tweaking.
Comment 6 Andre Klapper 2014-11-15 12:12:23 UTC 
(In reply to Gabriel Wicke from comment #5)
> Right now this is deployed to group 1 wikis, but not yet to group 2. Lets
> keep this open until it has made its way there.

gwicke: So can this ticket be closed as FIXED?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links