Last modified: 2014-06-11 08:24:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68316, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66316 - Crash on revert
Crash on revert
Status: RESOLVED FIXED
Product: Huggle
Classification: Unclassified
Application (Other open bugs)
trunk
All Windows 7
: High critical
: ---
Assigned To: Peter Bena
:
Depends on:
Blocks: 34892
  Show dependency treegraph
 
Reported: 2014-06-07 12:09 UTC by se4598
Modified: 2014-06-11 08:24 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description se4598 2014-06-07 12:09:47 UTC
on Revert of an edit, running version fae0fd9e:

HG hangs, Microsoft Visual C++ Runtime Library error dialog with no further info, on clicking OK program finally exits.

Console log:
Sa Jun 7 14:03:38 2014   WARNING: Rollback token for edit VAndal could not be retrieved, fallback to manual edit
Sa Jun 7 14:03:42 2014   Successfully edit VAndal
Sa Jun 7 14:03:42 2014   DEBUG[1]: Sucessful SR of page VAndal
ASSERT failure in QCoreApplication::sendEvent: "Cannot send events to objects owned by a different thread. Current thread 2897c068. Receiver '' (of type 'Huggle::RevertQuery') was created in thread 28888138", file kernel\qcoreapplication.cpp, line 505
Invalid parameter passed to C runtime function.
Invalid parameter passed to C runtime function.
--- after clicking ok on dialog ---
LEAK: 37 RenderObject
LEAK: 1 Page
LEAK: 1 Frame
LEAK: 2 CachedResource
LEAK: 63 WebCoreNode
QWaitCondition: Destroyed while threads are still waiting
> debug\huggle.exe exited, return code 3
Comment 1 Peter Bena 2014-06-07 14:08:27 UTC
what is version fae0fd9e??
Comment 3 Peter Bena 2014-06-07 14:11:22 UTC
hm, can you send me a stack trace so that I can see where it crashed?
Comment 4 se4598 2014-06-07 15:05:45 UTC
Can't grab a exact stacktrace, but here is one good before crash:

the revert-query returns with (revertquery.cpp	192)
> this->timer->stop(); this->UnregisterConsumer(HUGGLECONSUMER_REVERTQUERYTMR);
but core.cpp at
> done = QApplication::notify(receiver, event);
runs also smooth through with breakpoint, I would bet that it happens there.
You also see in the stacktrace the QCoreApplication::sendEvent in the callchain?

-----
Thread #1
0	Huggle::RevertQuery::OnTick	revertquery.cpp	192	0x46458b	
1	Huggle::RevertQuery::qt_static_metacall	moc_revertquery.cpp	67	0x48b189	
2	QMetaObject::activate	qobject.cpp	3569	0x6b946890	
3	QMetaObject::activate	qobject.cpp	3444	0x6b946232	
4	QTimer::timeout	moc_qtimer.cpp	189	0x6b99e248	
5	QTimer::timerEvent	qtimer.cpp	255	0x6b94a19c	
6	QObject::event	qobject.cpp	1128	0x6b940daa	
7	QApplicationPrivate::notify_helper	qapplication.cpp	3482	0x206ddeb1	
8	QApplication::notify	qapplication.cpp	2903	0x206db7cd	
9	Huggle::HgApplication::notify	core.cpp	486	0x41c1f1	
10	QCoreApplication::notifyInternal	qcoreapplication.cpp	881	0x6b91b91c	
11	QCoreApplication::sendEvent	qcoreapplication.h	232	0x6b9bf427	
12	QEventDispatcherWin32Private::sendTimerEvent	qeventdispatcher_win.cpp	585	0x6b965747	
13	qt_internal_proc	qeventdispatcher_win.cpp	426	0x6b965012	
14	USER32!OffsetRect	C:\Windows\syswow64\user32.dll		0x76c162fa	
15	??			0x3d0fbe	
16	USER32!IsWindow	C:\Windows\syswow64\user32.dll		0x76c16d3a	
17	__lambda0::operator()	qeventdispatcher_win.cpp	364	0x6b964d03	
18	??			0x3d0fbe	
19	USER32!AnyPopup	C:\Windows\syswow64\user32.dll		0x76c177c4	
20	??				
...	<Mehr>
Comment 5 Peter Bena 2014-06-08 15:08:51 UTC
ok does it happen on every revert?
Comment 6 se4598 2014-06-08 15:43:35 UTC
"fixed" with disabling the new multithreaded GC : https://github.com/huggle/huggle3-qt-lx/commit/cfaa99fe1507ea4c4f6983c703974c4e502be4ad
Comment 7 Peter Bena 2014-06-09 07:21:35 UTC
this should be fixed now
Comment 8 Peter Bena 2014-06-11 08:08:47 UTC
you shouldn't use MSVC as it doesn't support c++11 yet, I tried this and it works fine to me, maybe it's compiler related
Comment 9 Peter Bena 2014-06-11 08:16:03 UTC
hm... now i see it

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links