Last modified: 2014-07-01 15:02:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68353, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66353 - VisualEditor: Cannot resize frame image in MediaWiki, but can in VisualEditor(?)
VisualEditor: Cannot resize frame image in MediaWiki, but can in VisualEditor(?)
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-06-12
Assigned To: Moriel Schottlender
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-08 22:34 UTC by vojtech.dostal@wikimedia.cz
Modified: 2014-07-01 15:02 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description vojtech.dostal@wikimedia.cz 2014-06-08 22:34:15 UTC
A student of Education program at Czech Wikipedia noticed that she cannot resize an image which is inserted as a frame. It is well possible to adjust the size in the preview mode, but saving it does not produce appropriately resized image frame. 


see image under heading "Půdorys" at:
https://cs.wikipedia.org/wiki/Kostel_Nanebevzet%C3%AD_Panny_Marie_%28Charvatce%29

Thank you
Vojtěch Dostál
Comment 1 James Forrester 2014-06-09 06:11:32 UTC
Thanks for this bug; it seems like a regression(?!) in MediaWiki. Moriel, can you confirm?
Comment 2 Moriel Schottlender 2014-06-09 16:23:58 UTC
Yes, after a bit of analysis, I believe there's a problem with the way the scalable object analyzes default vs custom values. I'm working on refactoring the way that works; we have a tech debt about this, too, I believe.
Comment 3 Gerrit Notification Bot 2014-06-09 18:49:20 UTC
Change 138388 had a related patch set uploaded by Mooeypoo:
Disable the size widget for 'frame' images

https://gerrit.wikimedia.org/r/138388
Comment 4 Moriel Schottlender 2014-06-09 18:51:43 UTC
Scratch my last remark. There is still a technical debt (that is being taken care of) about default vs. custom size but the issue in this case is that we don't follow the wikitext rules properly. 

Frame images ignore size specification. 
See wikitext documentation here: https://www.mediawiki.org/wiki/Help:Images#Size_and_frame
Comment 5 Gerrit Notification Bot 2014-06-10 18:51:24 UTC
Change 138388 merged by jenkins-bot:
Disable the size widget for 'frame' images

https://gerrit.wikimedia.org/r/138388

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links