Last modified: 2014-08-13 16:55:17 UTC
To ensure consistency of rendering between Production and Labs tools. Reported by Jarry1250 for inconsistency between font rendering.
We included the fonts packages for bug #58740 in exec nodes in February (since then replaced by ::mediawiki::multimedia::fonts). Due to the way in which I wrote the patch (*1), this is limited to exec nodes only, i. e. they are not installed on tools-login/tools-dev or webnodes. Is that what is missing here? (*1) At that time, IIRC I initially wanted to include them in exec_environ, but then (mis-)read the coding conventions that classes shouldn't include other classes, but that these should be set up in roles instead. Rereading [[wikitech:Puppet usage]], I can't find any such restriction, and IMHO putting it in exec_environ that is included in exec nodes, bastions and webnodes is The Right Thing(TM).
(In reply to Tim Landscheidt from comment #1) > We included the fonts packages for bug #58740 in exec nodes in February > (since then replaced by ::mediawiki::multimedia::fonts). Due to the way in > which I wrote the patch (*1), this is limited to exec nodes only, i. e. they > are not installed on tools-login/tools-dev or webnodes. Is that what is > missing here? Yes. Please include ::mediawiki::multimedia::fonts on webnodes.
Change 151440 had a related patch set uploaded by Tim Landscheidt: Tools: Include mediawiki::multimedia::fonts in exec_environ https://gerrit.wikimedia.org/r/151440
Change 151440 merged by coren: Tools: Include mediawiki::multimedia::fonts in exec_environ https://gerrit.wikimedia.org/r/151440
