Last modified: 2014-09-22 18:44:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68366, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66366 - Improve Error handling: api-error-unknownerror
Improve Error handling: api-error-unknownerror
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
master
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 67197 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-09 12:10 UTC by Steinsplitter
Modified: 2014-09-22 18:44 UTC (History)
14 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot 1 (32.87 KB, image/png)
2014-06-09 12:10 UTC, Steinsplitter
Details
screenshot 2 (49.54 KB, image/png)
2014-06-09 12:11 UTC, Steinsplitter
Details
screenshot 3 (49.63 KB, image/png)
2014-06-11 18:04 UTC, Marco
Details
no name checking (126.88 KB, image/png)
2014-06-12 12:13 UTC, Nicolas Raoul
Details
reproduced (24.06 KB, image/png)
2014-06-15 05:14 UTC, Nicolas Raoul
Details
Firefox addons (96.11 KB, image/png)
2014-06-15 06:30 UTC, Nicolas Raoul
Details

Description Steinsplitter 2014-06-09 12:10:52 UTC
Created attachment 15599 [details]
screenshot 1

Error handling should be improved, such error outputs are not helpful for users:
api-error-unknownerror

(screenshots by Nicolas_Raoul via IRC)
Comment 1 Steinsplitter 2014-06-09 12:11:48 UTC
Created attachment 15600 [details]
screenshot 2
Comment 2 Nicolas Raoul 2014-06-09 12:17:00 UTC
Thanks!
Ask me any details, though I guess you can reproduce it easily.
Comment 4 Fastily 2014-06-11 05:37:53 UTC
Overly frequent breakage has been persistent issue which has hampered the upload process for nearly two years now.  It's frustrating enough for seasoned users, and I can only imagine the grievances it causes for newbies (*especially* those on slower internet connections and/or those with bandwidth/data caps).

This could possibly be related to bug 36587, which, AFAIK still results in failures when upload speed is throttled to < 1mpbs second.
Comment 5 Marco 2014-06-11 14:28:32 UTC
How do you even get to the upload. (I thought file names including a '/' are not allowed)
Comment 6 Nicolas Raoul 2014-06-11 14:45:37 UTC
@Marco:
See screenshot 2.
Anything seems to be allowed as a title.
Comment 7 Marco 2014-06-11 18:04:58 UTC
Created attachment 15628 [details]
screenshot 3

Attached is a screenshot taken in my universe.
Comment 8 Derk-Jan Hartman 2014-06-12 10:44:05 UTC
@nicolas, what kind of browser and version of the browser do you have ?
Comment 9 Nicolas Raoul 2014-06-12 12:13:14 UTC
Created attachment 15638 [details]
no name checking
Comment 10 Nicolas Raoul 2014-06-12 12:14:28 UTC
Default Firefox 29.0 on fully-updated Ubuntu 2014.04

As seen on screenshot above, no character trigger any warning.
Comment 11 Marco 2014-06-14 10:11:12 UTC
I can't reproduce but I think this bug is still valid. I'd guess you received one of the random "API outage errors" (503 et al. , though not sure)


If the above is correct a solution would be to retry once and/or pass a more meaningful error message?
Comment 12 Rainer Rillke @commons.wikimedia 2014-06-14 10:41:02 UTC
(In reply to Marco from comment #11)
Issues I see from the screenshot 1:

1) Looks like a missing MediaWiki message
2) Title was not validated before submitted
3) Title is an invalid file title (for uploading) -- can someone please +2 I260ba883548975263bb ?



1) https://commons.wikimedia.org/wiki/MediaWiki:Api-error-unkownerror does not exist -- don't know whether it's still used anywhere in UploadWizard
2) Still an issue. UploadWizard asks the TitleBlacklist and Protection for a title in the Gallery namespace, not in the file namespace

action	titleblacklist
format	json
tbaction	create
tbtitle	XN Sympetrum sanguineum w prey 658.JPG

action	query
format	json
iiprop	url|mime|size
iiurlwidth	150
inprop	protection
prop	info|imageinfo
titles	XN Sympetrum sanguineum w prey 658.JPG
Comment 13 Gerrit Notification Bot 2014-06-14 11:41:53 UTC
Change 139592 had a related patch set uploaded by Rillke:
Create title in file NS and validate as such

https://gerrit.wikimedia.org/r/139592
Comment 14 Rainer Rillke @commons.wikimedia 2014-06-14 11:43:43 UTC
Note that I1ed825b05ea80b41 won't solve the issue that invalid file titles (for uploading) containing slashes are not detected.
Comment 15 Rainer Rillke @commons.wikimedia 2014-06-14 11:44:13 UTC
(In reply to Rainer Rillke @commons.wikimedia from comment #14)
... are not detected before finally submitting.
Comment 16 Nicolas Raoul 2014-06-14 13:26:16 UTC
I can reproduce the error any time, so if there is a way to test any patch, please let me know whenever you want me to test :-)
In particular if there is a kind of "beta server" where I can test the latest development version.
Comment 17 Marco 2014-06-14 17:32:46 UTC
(In reply to Nicolas Raoul from comment #16)
> I can reproduce the error any time

Do you mean the 'api-error-unknownerror'? (I tried it with FF29 on Ubuntu1404 and I got the same response as seen in screenshot 3 [attachment 15628 [details] ])
Comment 18 Nicolas Raoul 2014-06-15 05:14:48 UTC
Created attachment 15658 [details]
reproduced
Comment 19 Nicolas Raoul 2014-06-15 05:15:17 UTC
@Marco: Yes, reproduced just now, see screenshot above.
Comment 20 Rainer Rillke @commons.wikimedia 2014-06-15 06:24:05 UTC
Nicolas Raoul,
1) Are you using UploadWizard at Wikimedia Commons for reproducing?
   If not, how does your setup look like. I.e. are you using the titleblacklist?
2) Does the file system, the file comes from support slashes in file names: Did you change the destination title after uploading or is it the file name? If you changed the file name after uploading, what was the original name of the file?
Comment 21 Nicolas Raoul 2014-06-15 06:29:50 UTC
1) Using https://commons.wikimedia.org/wiki/Special:UploadWizard

2) Filesystem name is amarok-unity-tray-icon.png but I inserted a slash in the "Title" field of the "Describe" step.

I am using the Firefox addons listed in the screenshot below.
Comment 22 Nicolas Raoul 2014-06-15 06:30:22 UTC
Created attachment 15660 [details]
Firefox addons
Comment 23 Pine 2014-07-02 18:29:08 UTC
Note: bug 67197 appears to be similar or a duplicate of this bug
Comment 24 Marco 2014-07-02 20:50:14 UTC
*** Bug 67197 has been marked as a duplicate of this bug. ***
Comment 25 Gerrit Notification Bot 2014-09-15 12:24:28 UTC
Change 139592 merged by jenkins-bot:
Create title in file NS and validate as such

https://gerrit.wikimedia.org/r/139592
Comment 27 Tisza Gergő 2014-09-22 18:39:41 UTC
Slightly related: https://gerrit.wikimedia.org/r/#/c/161363/
Comment 28 Tisza Gergő 2014-09-22 18:42:26 UTC
(In reply to Steinsplitter from comment #26)
> https://commons.wikimedia.org/wiki/Commons:
> Upload_help#Receiving_error_at_the_end_of_uploading...

The section was renamed to
https://commons.wikimedia.org/w/index.php?title=Commons:Upload_help&oldid=135156032#Error_at_the_end_of_uploading

and the issue mentioned there is bug 70617.
Comment 29 Steinsplitter 2014-09-22 18:44:02 UTC
(In reply to Tisza Gergő from comment #28)
> (In reply to Steinsplitter from comment #26)
> > https://commons.wikimedia.org/wiki/Commons:
> > Upload_help#Receiving_error_at_the_end_of_uploading...
> 
> The section was renamed to
> https://commons.wikimedia.org/w/index.php?title=Commons:
> Upload_help&oldid=135156032#Error_at_the_end_of_uploading
> 
> and the issue mentioned there is bug 70617.

Oh, indeed. Patch merged, *closing this*.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links