Last modified: 2014-07-23 12:17:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68375, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66375 - Upload icon for anon no longer appears
Upload icon for anon no longer appears
Status: RESOLVED INVALID
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
: browser-test-bug
Depends on: 62598
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-09 16:05 UTC by Chris McMahon
Modified: 2014-07-23 12:17 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2014-06-09 16:05:58 UTC
As anonymous user at http://en.m.wikipedia.beta.wmflabs.org

Click Random, get result e.g. http://en.m.wikipedia.beta.wmflabs.org/wiki/0.4646705591863669_Moved#/random 

Page should contain an upload icon (with a lock symbol I think) which when clicked yields a "you must login" message, but does not

$ bundle exec cucumber features/pageactions.feature:12
@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @test2.m.wikipedia.org
Feature: Page actions menu when anonymous

  Background:                                           # features/pageactions.feature:4
    Given I am on the "Main Page" page                  # features/step_definitions/common_steps.rb:90
    And I click on "Random" in the main navigation menu # features/step_definitions/mainmenu_steps.rb:5

  Scenario: Receive notification message - Upload Icon                            # features/pageactions.feature:12
    When I click on the upload icon                                               # features/step_definitions/lead_photo_steps.rb:1
      timed out after 5 seconds, waiting for {:id=>"ca-upload", :tag_name=>"li"} to become present (Watir::Wait::TimeoutError)
      ./features/step_definitions/lead_photo_steps.rb:2:in `/^I click on the upload icon$/'
      features/pageactions.feature:13:in `When I click on the upload icon'
    Then I see a toast with message "Please log in to add an image to this page." # features/step_definitions/common_article_steps.rb:62

Failing Scenarios:
cucumber features/pageactions.feature:12 # Scenario: Receive notification message - Upload Icon
Comment 1 Chris McMahon 2014-06-09 16:09:48 UTC
Also missing for logged-in new user: 

$ bundle exec cucumber features/uploads_lead_tutorial.feature:8
@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @login @test2.m.wikipedia.org
Feature: Lead image tutorial

  Background:                                   # features/uploads_lead_tutorial.feature:4
    Given I am logged in as a new user          # features/step_definitions/common_steps.rb:58
    And I am on the "Nonexistent_page_abc" page # features/step_definitions/common_steps.rb:90

  Scenario: There is an upload button                      # features/uploads_lead_tutorial.feature:8
    Then there is an upload an image to this page button   # features/step_definitions/lead_photo_steps.rb:5
      expected #<Watir::LI:0x241240de844ea8e0 located=false selector={:id=>"ca-upload", :tag_name=>"li"}> to exist (RSpec::Expectations::ExpectationNotMetError)
      ./features/step_definitions/lead_photo_steps.rb:6:in `/^there is an upload an image to this page button$/'
      features/uploads_lead_tutorial.feature:9:in `Then there is an upload an image to this page button'
    And the upload an image to this page button is enabled # features/step_definitions/lead_photo_steps.rb:9

Failing Scenarios:
cucumber features/uploads_lead_tutorial.feature:8 # Scenario: There is an upload button
Comment 2 Bingle 2014-06-09 16:10:18 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/yXevl4lK
Comment 3 Florian 2014-06-09 16:26:39 UTC
Caused by change https://gerrit.wikimedia.org/r/#/c/137461/
Which restricts the visibility of upload button to autoconfirmed users. If i'm right in context to https://bugzilla.wikimedia.org/show_bug.cgi?id=62598#c41
Comment 4 Jon 2014-06-09 17:19:51 UTC
This is by design. See https://trello.com/c/jHKLcZ0j/7-5-only-allow-uploads-by-auto-confirmed-users

I'll clean up the tests now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links