Last modified: 2014-08-14 01:39:35 UTC
Created attachment 15609 [details] Screenshot Steps to reproduce: 1.Open a page with Image 2.Open the Media Settings dialog 3.Now quickly double click on Apply changes Button Observed Result: An error appears in the console: Uncaught TypeError: Cannot read property 'getSurface' of null Media Settings dialog for that image and all other images on that page becomes unresponsive. This is happening in Betalabs and test , not on production(en.wiki) See the screenshot attached
Change 139019 had a related patch set uploaded by Trevor Parscal: Re-enable apply button in action dialog on close https://gerrit.wikimedia.org/r/139019
Change 139019 merged by jenkins-bot: Re-enable apply button in action dialog on close https://gerrit.wikimedia.org/r/139019
Verified the fix on Betalabs
Verified the fix on test2
Verified the fix in production (en.wiki)
This problem still exist on snapshot 9883566 (https://extdist.wmflabs.org/dist/VisualEditor-REL1_23-9883566.tar.gz).
(In reply to Coiby from comment #6) > This problem still exist on snapshot 9883566 > (https://extdist.wmflabs.org/dist/VisualEditor-REL1_23-9883566.tar.gz). I just look through the patch, I can't find such file ve/ui/dialogs/ve.ui.ActionDialog.json in snapshot 9883566.
(In reply to Coiby from comment #7) > (In reply to Coiby from comment #6) > > This problem still exist on snapshot 9883566 > > (https://extdist.wmflabs.org/dist/VisualEditor-REL1_23-9883566.tar.gz). > > I just look through the patch, I can't find such file > ve/ui/dialogs/ve.ui.ActionDialog.json in snapshot 9883566. .js , not .json . Also, try looking for lib/ve/modules/ve/ui/dialogs/ve.ui.ActionDialog.js
Sorry, it's typo. I mean .js. There are two files related to Media Seetings dialogue, ve.ui.MWMediaInsertDialog.js and ve.ui.MWMediaEditDialog.js. There's no ve.ui.ActionDialog.js.
Right, ActionDialog.js was introduced after the 1.23 release. I thought this bug was introduced after the 1.23 release though, so I'm surprised to hear it's breaking for you.
(In reply to Roan Kattouw from comment #10) > Right, ActionDialog.js was introduced after the 1.23 release. I thought this > bug was introduced after the 1.23 release though, so I'm surprised to hear > it's breaking for you. So will the development team resolve this bug for 1.23?
