Last modified: 2014-06-20 21:38:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68396, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66396 - VisualEditor:Getting "Your edit may have been corrupted – please review before saving" message while making changes to an image in the page
VisualEditor:Getting "Your edit may have been corrupted – please review befo...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-06-12
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-09 23:50 UTC by Rummana Yasmeen
Modified: 2014-06-20 21:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rummana Yasmeen 2014-06-09 23:50:45 UTC
I have been getting this issue since this morning, I think this has something to do with changing image size when the size of an image gets adjusted or changed.
I do not have the exact steps to reproduce for now.But it happened this one time when I changed the thumbnail left aligned image to centre float.

This is the page where you will see the image on which I made the change and getting the edit conflict error :
http://en.wikipedia.beta.wmflabs.org/wiki/9thjunechrome?veaction=edit

We had encountered similar kind of issue quiet a while ago, which was fixed:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62172

I am not sure, if the same cause is behind the bug or not
Comment 1 Roan Kattouw 2014-06-10 00:46:29 UTC
There is a very weird issue, probably introduced by Ed's extension nodes rewrite. Any extension node's children get duplicated on the way back to Parsoid: a hieroglyphs <table> gets two <tbody>s, a gallery <ul> contains all of its <li>s twice, etc.
Comment 2 Gerrit Notification Bot 2014-06-10 01:03:12 UTC
Change 138521 had a related patch set uploaded by Catrope:
Followup bd49f97: prevent MWExtensionNodes from having children

https://gerrit.wikimedia.org/r/138521
Comment 3 Gerrit Notification Bot 2014-06-10 01:07:25 UTC
Change 138521 merged by jenkins-bot:
Followup bd49f97: prevent MWExtensionNodes from having children

https://gerrit.wikimedia.org/r/138521
Comment 4 Rummana Yasmeen 2014-06-10 18:29:03 UTC
Verified the fix in Betalabs
Comment 5 Rummana Yasmeen 2014-06-13 23:58:51 UTC
Verified the fix in test2 running wmf 9
Comment 6 Rummana Yasmeen 2014-06-20 21:38:42 UTC
Verified the fix in production (en.wiki)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links