Last modified: 2014-07-22 11:47:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68441, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66441 - Create a "MediaWiki skins" product, with a component for each of the core skins
Create a "MediaWiki skins" product, with a component for each of the core skins
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
wmf-deployment
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Tyler Romeo
:
Depends on:
Blocks: 50191
  Show dependency treegraph
 
Reported: 2014-06-10 18:36 UTC by Bartosz Dziewoński
Modified: 2014-07-22 11:47 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2014-06-10 18:36:17 UTC
Please create a "MediaWiki skins" product, with a component for each of the core skins (CologneBlue, MonoBook, Modern, Vector).

As we're working on separating the repositories, it makes sense to also separate Bugzilla components ([[mw:Separating skins from core MediaWiki]]).

Right now bugs in skins are mostly polluting the "Skin and page rendering" component of core, which really should only include bugs which are valid regardless of the skin in use. (Some skins at least have tracking bugs, their dependency trees could be moved to the new components.)

Non-core skins could be also put under this product (see e.g. bug 50191).
Comment 1 Isarra 2014-06-11 01:24:34 UTC
YES. YES. YES.
Comment 2 Andre Klapper 2014-06-11 09:48:24 UTC
Which components would such a product have (preferably with description, default assignee or CC, and some link to some 'homepage')?
Comment 3 Tyler Romeo 2014-06-16 16:47:05 UTC
Here's my proposal. If people like it I can create it:

Product: MediaWiki skins

Description: Skins that can be used in MediaWiki. Use to report bugs or visual defects in MediaWiki skins, including built-in skins and those installable via extensions. If an extension contains both a skin and other components, only skin-related defects should be reported in this product.

Components: CologneBlue, MonoBook, Modern, Vector

Default CCes: For all except Vector, it makes sense to keep the existing defaults from the existing "Skin and page rendering" component in MediaWiki. However, for Vector, it has its own component under MediaWiki extensions, so we'd take the CCes and assignees from there.
Comment 4 Isarra 2014-06-16 23:37:34 UTC
(In reply to Tyler Romeo from comment #3)
> Here's my proposal. If people like it I can create it:
> 
> Product: MediaWiki skins
> 
> Description: Skins that can be used in MediaWiki. Use to report bugs or
> visual defects in MediaWiki skins, including built-in skins and those
> installable via extensions. If an extension contains both a skin and other
> components, only skin-related defects should be reported in this product.

Basically this, aside from the last bit. If an extension happens to include a skin, relevant bugs should still probably all remain in a single extension component so everything stays together. A separate component should only be created if the extension itself is broken up.

Unless, that is, it's like bluespice and happens to be basically a disaster of extension chunks, but in such cases there's no hope of logical organisation anyway so there's no point worrying about that.

> Components: CologneBlue, MonoBook, Modern, Vector
> 
> Default CCes: For all except Vector, it makes sense to keep the existing
> defaults from the existing "Skin and page rendering" component in MediaWiki.
> However, for Vector, it has its own component under MediaWiki extensions, so
> we'd take the CCes and assignees from there.

Yeah. This is just an equivalent product to extensions, but for skins, and the current components would be the core skins, with other skins added as people request them, just like with extensions.

Mind, the Vector extension isn't quite the same as the skin, and while it was by the same folks and the skin and extension were eventually merged, I'm not sure the CCs are still applicable anymore. Possibly something to consider, I don't know.

We will also want to move any skins that currently use extension components to use skin components. I only noticed one for Chameleon, but there may be others. (This can be done later, though, I'm sure.)
Comment 5 Bartosz Dziewoński 2014-06-16 23:44:50 UTC
Sorry, I've been meaning to reply sooner. I agree with everything Tyler and Isarra said.

There are home pages for core skins on mediawiki.org: [[mw:Skin:Vector]] and so on.

Regardless on what you decide about default assignees and CCs, I want to be a default CC on the four components for core skins.
Comment 6 Tyler Romeo 2014-06-17 02:21:05 UTC
OK, unless Andre objects I'll do it (trying to be more helpful since I only yesterday realized I wasn't on the default CC for the Bugzilla component :P).
Comment 7 Andre Klapper 2014-06-17 12:14:06 UTC
(In reply to Tyler Romeo from comment #3)
> Components: CologneBlue, MonoBook, Modern, Vector

...plus move "Chamaleon" to this new "MediaWiki skins" product (from MediaWiki extensions) and its 13 tickets, as mentioned in comment 4.

After doing so, the "Skin and page rendering" component in MediaWiki only refers to issues in MediaWiki core code generically dealing with (any) skin handling, right? I guess I'd need to make this clearer in its component description.

Also, will this mean that somebody (who?) would need to retriage existing tickets in the "Skin and page rendering" component and potentially move skin-specific issues to those new components? 370 open tickets. Urgh. :(
Comment 8 Tyler Romeo 2014-06-17 17:07:12 UTC
(In reply to Andre Klapper from comment #7)
> ...plus move "Chamaleon" to this new "MediaWiki skins" product (from
> MediaWiki extensions) and its 13 tickets, as mentioned in comment 4.
> 
> After doing so, the "Skin and page rendering" component in MediaWiki only
> refers to issues in MediaWiki core code generically dealing with (any) skin
> handling, right? I guess I'd need to make this clearer in its component
> description.
> 
> Also, will this mean that somebody (who?) would need to retriage existing
> tickets in the "Skin and page rendering" component and potentially move
> skin-specific issues to those new components? 370 open tickets. Urgh. :(

Done. 370 is a lot of tickets, so it will take a while, but I'll work on that.
Comment 9 Andre Klapper 2014-06-17 18:03:05 UTC
Uh, thanks. As you've created the new product already there's probably not much left for me to do here. :)
Comment 10 Tyler Romeo 2014-06-17 18:04:30 UTC
(In reply to Andre Klapper from comment #9)
> Uh, thanks. As you've created the new product already there's probably not
> much left for me to do here. :)

Well I have a bit of free time, and the entire purpose of me getting permissions to change Bugzilla products was to let you not have to do them. :P
Comment 11 Andre Klapper 2014-07-22 11:47:38 UTC
What was requested in the summary has been created, hence closing as fixed

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links