Last modified: 2014-08-06 04:01:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68490, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66490 - Upload icon appears after anonymous edit save
Upload icon appears after anonymous edit save
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
alpha (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-11 18:08 UTC by Florian
Modified: 2014-08-06 04:01 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screencapture (427.29 KB, video/x-ms-wmv)
2014-06-11 18:38 UTC, Florian
Details

Description Florian 2014-06-11 18:08:11 UTC
After Change https://gerrit.wikimedia.org/r/#/c/137462/ the upload icon does not appear, if no action is available.

If you edit a page in alpha mode as anonymous (wgMFAnonymousEditing or a maybe change from this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=59937#c15) and save an edit, the site is loading with javascript and the upload button is shown (disabled but visible). To be consistent, it's better to hide the upload button there, too :)
Comment 1 Bingle 2014-06-11 18:10:14 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Pe5yHhES
Comment 2 Jon 2014-06-11 18:16:03 UTC
The patch you mention hasn't been merged yet. I'm not 100% sure what the problem here is. When I check out the page, enable anonymous editing, I edit the page which needs no image, I still do not see the upload icon after the save is complete.

If there is a problem with the above patch could you please comment on that patchset?

Could you elaborate on the bug here - it's not clear to me at all. Screenshots/video might help.
Comment 3 Florian 2014-06-11 18:38:26 UTC
Ah, sorry, my fault. I mean this change:
https://gerrit.wikimedia.org/r/#/c/137461/

In attachment is a little video :) Main problem is that the edit button is deactivated, too. That i have seen in my change here:
https://gerrit.wikimedia.org/r/#/c/138802/
Comment 4 Florian 2014-06-11 18:38:48 UTC
Created attachment 15629 [details]
Screencapture
Comment 5 Jon 2014-06-11 19:14:26 UTC
Okay. It looks like https://gerrit.wikimedia.org/r/#/c/137462/ fixes this though.
Comment 6 Jon 2014-06-11 19:15:16 UTC
See Id10804beae1948942b1a4f62898904b7baf839a2 which hides this whenever it is not available.
Comment 7 Florian 2014-06-13 10:49:40 UTC
Is merged, and my test success, so will mark as fixed. Can be reopened, if necesary :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links