Last modified: 2014-06-11 23:50:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68500, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66500 - Upload page action should be disabled for file pages that already exist
Upload page action should be disabled for file pages that already exist
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-11 21:27 UTC by Ryan Kaldari
Modified: 2014-06-11 23:50 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2014-06-11 21:27:52 UTC
Right now, if you're logged in and you go to a page in the File namespace, there is an Upload page action button. It's not clear from the context what this button actually does, but given its function on article pages and the fact that it is a "page action", I would expect it to replace the current image on the file page with a newly uploaded image.

What it actually does is pretty nuts:
1. It uploads the new image to a new file page.
2. It creates a new main namespace page based on the name of the file page you were uploading from and inserts the new image into it.
3. It lazy-loads the main namespace page even though you are still in file namespace.

We could try to fix this, but I'm really not sure exactly what the correct behavior would be. Instead I think we should just disable the upload page action from within file pages (which is a 2 line change in modules/uploads/init.js).
Comment 1 Bingle 2014-06-11 21:30:15 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/tsl4Kj5p
Comment 2 Jon 2014-06-11 21:35:04 UTC
I think the purpose of this was to show an upload button on an empty file page - see bug 58311

The 3rd point seems like an issue. I think the second part is an oversight but the first point is correct behaviour.

Expected:
Should create file page using existing image.
Comment 3 Jon 2014-06-11 21:36:09 UTC
(We might want to revert the fix to bug 58311 in the meantime)
Comment 4 Gerrit Notification Bot 2014-06-11 22:21:35 UTC
Change 139009 had a related patch set uploaded by Kaldari:
Only show upload page action in File namespace if page doesn't already exist

https://gerrit.wikimedia.org/r/139009
Comment 5 Gerrit Notification Bot 2014-06-11 23:50:17 UTC
Change 139009 merged by jenkins-bot:
Only show upload page action in File namespace if page doesn't already exist

https://gerrit.wikimedia.org/r/139009

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links