Last modified: 2014-07-18 04:22:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68506, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66506 - Go directly to an article if we have an exact search match
Go directly to an article if we have an exact search match
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Florian
:
: 30884 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-12 00:06 UTC by Ryan Kaldari
Modified: 2014-07-18 04:22 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2014-06-12 00:06:23 UTC
A few months ago we changed the default search behavior so that it takes users to the search results page instead of an explicit match. The reasoning was:
* If the user has Javascript, they can click on a result from the drop-down.
* If the user doesn't have Javascript, we should send them to the full search results since they don't otherwise have a way to access it.

I was fairly skeptical of this approach when it was implemented, but decided to go along with it and see what the reaction was. We now have an official complaint, so I think we should revisit the issue.

Although it is more complicated to implement, I think the search bar should work as follows:
* If the user has Javascript, and they hit enter, the user should be sent to an exact match (if there is one).
* If the user doesn't have Javascript, and they hit enter, the user should be sent to the search results page regardless.

(The difference is whether we pass 'fulltext' in the search submission.)

Complaint can be read at https://en.wiktionary.org/wiki/Wiktionary:Grease_pit/2014/April#Diacritic_differentiation_in_search_box (skip the first few posts).
Comment 1 Ryan Kaldari 2014-06-12 00:07:30 UTC
*** Bug 30884 has been marked as a duplicate of this bug. ***
Comment 2 Bingle 2014-06-12 00:10:13 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/oZi8Usoh
Comment 3 Jon 2014-06-13 20:00:14 UTC
Copying complaint over before page is archived.

"As a sidenote, I personally don't like the new search engine AT ALL*, because when I use my mobile to view this website, I can't go to a page directly using the search box, I have to go through a searching page first. --kc_kennylau (talk) 15:50, 19 April 2014 (UTC)"

* Note AT ALL is in huge letters.
Comment 4 Gerrit Notification Bot 2014-06-13 21:55:54 UTC
Change 139556 had a related patch set uploaded by Florianschmidtwelzow:
Proposal: Redirect to direct match in search

https://gerrit.wikimedia.org/r/139556
Comment 5 Ryan Kaldari 2014-06-14 02:19:24 UTC
I like Florian's patch since it only affects Javascript users, although I would prefer to bind it to the submit event itself rather than a 'return' keypress.

As to whether or not this is the optimal behavior, I have no idea, although it seems more intuitive to me and matches the behavior of desktop search. Could we get some input from the design team (and maybe some user testing as a bonus)?
Comment 6 Florian 2014-06-28 15:23:52 UTC
> I would prefer to bind it to the submit event itself rather than a 'return'
> keypress.

A time ago i have edited the change to use submit instead of keypress (as information) :)
Comment 7 Ryan Kaldari 2014-07-14 18:12:53 UTC
CCing Maryana for product approval.
Comment 8 Maryana Pinchuk 2014-07-14 19:50:49 UTC
Yes, please! This has been bothering me for awhile.
Comment 9 Ryan Kaldari 2014-07-15 18:49:23 UTC
Fixed (for the most part). The functionality is currently dependent on the speed of the API response, however, so we may want to revisit if it proves flaky.
Comment 10 Gerrit Notification Bot 2014-07-15 18:49:32 UTC
Change 139556 merged by jenkins-bot:
Redirect directly to a match in search

https://gerrit.wikimedia.org/r/139556
Comment 11 Gerrit Notification Bot 2014-07-17 17:56:12 UTC
Change 147161 had a related patch set uploaded by Kaldari:
Simpler and more reliable solution for bug 66506

https://gerrit.wikimedia.org/r/147161
Comment 12 Gerrit Notification Bot 2014-07-18 01:53:12 UTC
Change 147161 merged by jenkins-bot:
Simpler and more reliable solution for bug 66506

https://gerrit.wikimedia.org/r/147161

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links