Last modified: 2014-06-13 10:28:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68511, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66511 - Translate should not use deprecated $wgProxyKey global


Summary:	Translate should not use deprecated $wgProxyKey global

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Translate (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Highest normal (vote)
Target Milestone:	MW 1.24 version
Assigned To:	Harsh Kothari

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-06-12 00:58 UTC by Kevin Israel (PleaseStand)
Modified:	2014-06-13 10:28 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kevin Israel (PleaseStand) 2014-06-12 00:58:04 UTC

TranslationHelpers::makeGoogleQueryParams() should not use $wgProxyKey, which has been deprecated since 1.14 and was removed in 1.24 (5e48ad2e78ce). It should instead use $wgSecretKey if necessary.

Comment 1 Gerrit Notification Bot 2014-06-12 19:06:54 UTC

Change 139170 had a related patch set uploaded by Harshkothari410:
Added $wgSecretKey instead of $wgProxyKey in TranslationHelpers::makeGoogleQueryParams()

https://gerrit.wikimedia.org/r/139170

Comment 2 Gerrit Notification Bot 2014-06-13 10:28:28 UTC

Change 139170 merged by jenkins-bot:
Added $wgSecretKey instead of $wgProxyKey in TranslationHelpers::makeGoogleQueryParams()

https://gerrit.wikimedia.org/r/139170

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links