Last modified: 2014-06-24 21:07:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68514, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66514 - Magic word strings aren't nowikid if the relevant DOM node is not in a start-of-line context
Magic word strings aren't nowikid if the relevant DOM node is not in a start-...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-12 05:49 UTC by James Forrester
Modified: 2014-06-24 21:07 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2014-06-12 05:49:53 UTC
Right now they're not, which is irritating when I'm writing about how VE supports the functionality. :-)
Comment 1 ssastry 2014-06-17 18:14:13 UTC
See https://en.wikipedia.org/w/index.php?title=User%3ASsastry%2FVE_Test&diff=613314757&oldid=584723202

and also this:

[subbu@earth lib] echo "This is a test of __DISAMBIG__ getting nowikied" | node parse --html2wt
This is a test of <nowiki>__DISAMBIG__</nowiki> getting nowikied
Comment 2 James Forrester 2014-06-17 18:19:42 UTC
See e.g. https://www.mediawiki.org/w/index.php?title=VisualEditor/status&diff=prev&oldid=1034135 for an insertion without <nowiki>s, or https://www.mediawiki.org/w/index.php?title=VisualEditor:Bug_66514&oldid=1039124 for a more minimal test.

The problem appears to be that <code>__Foo__</code> stops __Foo__ being recognised.
Comment 3 ssastry 2014-06-17 18:24:58 UTC
[subbu@earth lib] echo "<b>__TOC__</b>" | node parse --html2wt
'''__TOC__'''
[subbu@earth lib] echo "<foobar>__DISAMBIG__</foobar>" | node parse --html2wt
<foobar>__DISAMBIG__</foobar>
Comment 4 ssastry 2014-06-17 18:29:06 UTC
[subbu@earth lib] echo "Fails when not in <b>sol context</b> __TOC__" | node parse --html2wt --trace wt-escape
[wt-esc]       | EWT: "Fails when not in "
[wt-esc]       | ---No-checks needed---
[wt-esc]       | EWT: "sol context"
[wt-esc]       | ---No-checks needed---
[wt-esc]       | EWT: " __TOC__"
[wt-esc]       | SOL: false " __TOC__"
[wt-esc]       | ---Not-SOL and safe---
Fails when not in '''sol context''' __TOC__
[subbu@earth lib] echo "Works when node is in sol context __TOC__" | node parse --html2wt --trace wt-escape
[wt-esc]       | EWT: "Works when node is in sol context __TOC__"
[wt-esc]       | SOL: true "Works when node is in sol context __TOC__"
[wt-esc]       | nl: true :text= "Works when node is in sol context __TOC__"
[wt-esc]       | T: "Works when node is in sol context "
[wt-esc]       | T: {"type":"SelfclosingTagTk","name":"behavior-switch","attribs":[{"k":"word","v":"__TOC__"}],"dataAttribs":{"tsr":[34,41],"src":"__TOC__"}}
[wt-esc]       | ---Found WT tokens---
Works when node is in sol context <nowiki>__TOC__</nowiki>
Comment 5 Gerrit Notification Bot 2014-06-17 20:00:22 UTC
Change 140194 had a related patch set uploaded by Subramanya Sastry:
(Bug 66514) Fix bug in nowiki-escaping of magic words

https://gerrit.wikimedia.org/r/140194
Comment 6 Gerrit Notification Bot 2014-06-19 21:07:43 UTC
Change 140194 merged by jenkins-bot:
(Bug 66514) Fix bug in nowiki-escaping of magic words

https://gerrit.wikimedia.org/r/140194

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links