Last modified: 2014-11-05 00:42:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68547, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66547 - Flow: HTML entities are double-escaped in placeholder text for a reply


Summary:	Flow: HTML entities are double-escaped in placeholder text for a reply

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Flow (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Erik Bernhardson

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-06-12 19:07 UTC by spage
Modified:	2014-11-05 00:42 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-06-12 19:07:42 UTC

We fixed bug 65143 so that HTML entities aren't double-escaped when you edit.

But they are still double-escaped in no-JS (bug 66227)
and in placeholder text for a comment on a topic.

I.e. if the topic title has <>"& . the placeholder text in the add a comment textarea is
  Comment on "&lt;&gt;&quot;&amp;"

Comment 1 Quiddity 2014-08-01 04:43:35 UTC

On trello at https://trello.com/c/tCfkCAgA/

Comment 2 Jon 2014-09-04 13:44:03 UTC

Looks fine to me.
If I create a reply with text "''test'' do be doo" the placeholder renders like so without JavaScript which is valid HTML:


		<textarea id="flow-post-s1pc47n64spmrjsn-form-content"
				name="topic_content"
				required
				data-flow-preview-template="flow_post"
				data-flow-expandable="true"
				class="mw-ui-input"
				type="text"
				placeholder="Reply to &quot;&#x27;&#x27;&#x27;test&#x27;&#x27;&#x27; do be doo&quot;"
				data-role="content"></textarea>

Similarly with the text "<div>foo</div>
the placeholder is just "foo"

Comment 3 Matthew Flaschen 2014-10-09 04:36:42 UTC

Broken again.  See http://en.wikipedia.beta.wmflabs.org/wiki/Topic:Ryngpk7gt93ir9of .  It's now:

		<textarea id="flow-post-ryngpk7gt93ir9of-form-content"
				name="topic_content"
				required
				data-flow-preview-template="flow_post"
				data-flow-expandable="true"
				class="mw-ui-input"
				type="text"
				placeholder="Reply to &quot;&#x27; &amp;quot; &amp;gt; &amp;lt; ? / . , [ ] { } \ | ) ( * &amp;amp; ^ % $ # @ ! ~ `&quot;"
				data-role="content"></textarea>

and the topic title is:

' " > < ? / . , [ ] { } \ | ) ( * & ^ % $ # @ ! ~ `

Comment 4 Matthew Flaschen 2014-10-09 04:38:06 UTC

It's broken with and without JavaScript.

Comment 5 Gerrit Notification Bot 2014-10-09 18:16:17 UTC

Change 161101 had a related patch set uploaded by EBernhardson:
Explicitly treat Message plaintext parameters as plaintext

https://gerrit.wikimedia.org/r/161101

Comment 6 Gerrit Notification Bot 2014-10-13 13:43:33 UTC

Change 161101 merged by jenkins-bot:
Explicitly treat Message plaintext parameters as plaintext

https://gerrit.wikimedia.org/r/161101

Comment 7 Matthew Flaschen 2014-11-04 23:42:10 UTC

Still present.  See http://en.wikipedia.beta.wmflabs.org/wiki/Topic:Ryngpk7gt93ir9of .

Comment 8 Matthew Flaschen 2014-11-05 00:42:46 UTC

Never mind, it looks like this was also Varnish caching.

Working now, with or without JS.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links