Last modified: 2014-07-16 11:54:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68554, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66554 - Uncaught TypeError: object is not a function
Uncaught TypeError: object is not a function
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Highest major (vote)
: ---
Assigned To: Wikidata bugs
https://pt.wikipedia.org/wiki/Truth?d...
: javascript
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-12 20:26 UTC by Helder
Modified: 2014-07-16 11:54 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2014-06-12 20:26:59 UTC
If access the URL above using Google Chrome and I try to add a link to dewiki, I get
> Uncaught TypeError: object is not a function 
from a line which contains this:
>				: this.options.source( term );
in the file
https://bits.wikimedia.org/static-1.24wmf8/extensions/Wikidata/extensions/ValueView/lib/jquery.ui/jquery.ui.suggester.js
and I can't finish the edit.

The call stack is like this:
Uncaught TypeError: object is not a function jquery.ui.suggester.js:497
$.widget._getSuggestions jquery.ui.suggester.js:497
$.widget.search jquery.ui.suggester.js:415
(anonymous function) jquery.wikibase.siteselector.js:50
(anonymous function) jquery.event.special.eachchange.js:60
jQuery.event.dispatch load.php?debug=true&lang=pt&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Clo…:4641
jQuery.event.add.elemData.handle load.php?debug=true&lang=pt&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Clo…:4309
Comment 1 Adrian Lang 2014-06-13 07:51:19 UTC
I remember having seen this, but I can't reproduce it with master/master nor with mw1.24-wmf8/0.6.1 (that's what's deployed, right?).
Comment 2 Liangent 2014-06-13 09:34:55 UTC
Confirming in Firefox 28. Also reported by other users on zhwiki.
Comment 3 Liangent 2014-06-13 09:41:36 UTC
This also sometimes happens when sitelinks are being added on WikibaseRepo site; jquery.ui.suggester.js is also used there.
Comment 4 Gerrit Notification Bot 2014-06-13 14:23:15 UTC
Change 139369 had a related patch set uploaded by Tobias Gritschacher:
Fix Client widget according to new suggester interface

https://gerrit.wikimedia.org/r/139369
Comment 5 Gerrit Notification Bot 2014-06-13 14:44:10 UTC
Change 139369 merged by jenkins-bot:
Fix Client widget according to new suggester interface

https://gerrit.wikimedia.org/r/139369
Comment 6 Gerrit Notification Bot 2014-06-13 15:41:46 UTC
Change 139404 had a related patch set uploaded by Hoo man:
Fix Client widget according to new suggester interface

https://gerrit.wikimedia.org/r/139404
Comment 7 Gerrit Notification Bot 2014-06-13 16:02:47 UTC
Change 139404 merged by jenkins-bot:
Fix Client widget according to new suggester interface

https://gerrit.wikimedia.org/r/139404
Comment 8 Marius Hoch 2014-06-13 16:21:04 UTC
I'm going to deploy the fix today, so that this bug will be fixed in max. 2h if everything goes right.
Comment 9 Liangent 2014-06-13 16:23:45 UTC
(In reply to Marius Hoch from comment #8)
> I'm going to deploy the fix today, so that this bug will be fixed in max. 2h
> if everything goes right.

Also fixed in Repo?
Comment 10 Marius Hoch 2014-06-13 16:33:07 UTC
(In reply to Liangent from comment #9)
> Also fixed in Repo?

The component described here is client only, if there is a repo bug, please open a new bug for that. (We're also going to deploy a JS fix for repo, but that's not yet going to affect Wikidata)
Comment 11 Liangent 2014-06-13 16:49:22 UTC
(In reply to Marius Hoch from comment #10)
> (In reply to Liangent from comment #9)
> > Also fixed in Repo?
> 
> The component described here is client only, if there is a repo bug, please
> open a new bug for that. (We're also going to deploy a JS fix for repo, but
> that's not yet going to affect Wikidata)

Not sure. We got a user report about this on zh:WP:VPT, but it's also mentioned there that adding sitelinks on repo doesn't work either. I can't reproduce this myself though.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links