Last modified: 2014-07-19 11:26:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68555, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66555 - Title::getTitleValue() fails because ContentHandlerDefaultModelFor() is called for interwiki page.
Title::getTitleValue() fails because ContentHandlerDefaultModelFor() is calle...
Status: NEW
Product: MediaWiki
Classification: Unclassified
ContentHandler (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-12 20:30 UTC by Yuri Astrakhan
Modified: 2014-07-19 11:26 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yuri Astrakhan 2014-06-12 20:30:04 UTC
In this stacktrace, a Title object is created for "v:", which is an interwiki page. $title->getTitleValue() silently fails (DB key is ""), and returns NULL, causing an error later on.

In reality, ContentHandlerDefaultModelFor( $title, &$modelId ) hook should probably not be called on such title objects.

[2014-06-12 19:45:23] Catchable fatal error: Argument 1 passed to JsonConfig\JCSingleton::getSettings() must be an instance of TitleValue, null given, called in /usr/local/apache/common-local/php-1.24wmf8/extensions/JsonConfig/includes/JCSingleton.php on line 359 and defined at /usr/local/apache/common-local/php-1.24wmf8/extensions/JsonConfig/includes/JCSingleton.php on line 293
Server: mw1184
Method: GET
URL: http://meta.wikimedia.org/wiki/v:
Cookie:
Backtrace:
#0 /usr/local/apache/common-local/php-1.24wmf8/extensions/JsonConfig/includes/JCSingleton.php(293): JsonConfig\JCSingleton::getSettings()
#1 /usr/local/apache/common-local/php-1.24wmf8/extensions/JsonConfig/includes/JCSingleton.php(359): JsonConfig\JCSingleton::getSettings(NULL)
#2 [internal function]: JsonConfig\JCSingleton::onContentHandlerDefaultModelFor(Object(Title), NULL)
#3 /usr/local/apache/common-local/php-1.24wmf8/includes/Hooks.php(206): call_user_func_array('JsonConfig\JCSi...', Array)
#4 /usr/local/apache/common-local/php-1.24wmf8/includes/GlobalFunctions.php(4056): Hooks::run('ContentHandlerD...', Array, NULL)
#5 /usr/local/apache/common-local/php-1.24wmf8/includes/content/ContentHandler.php(204): wfRunHooks('ContentHandlerD...', Array)
#6 /usr/local/apache/common-local/php-1.24wmf8/includes/Title.php(935): ContentHandler::getDefaultModelFor(Object(Title))
#7 /usr/local/apache/common-local/php-1.24wmf8/includes/WikiPage.php(524): Title->getContentModel()
#8 /usr/local/apache/common-local/php-1.24wmf8/includes/WikiPage.php(222): WikiPage->getContentModel()
#9 /usr/local/apache/common-local/php-1.24wmf8/includes/WikiPage.php(208): WikiPage->getContentHandler()
#10 /usr/local/apache/common-local/php-1.24wmf8/includes/actions/Action.php(92): WikiPage->getActionOverrides()
#11 /usr/local/apache/common-local/php-1.24wmf8/includes/actions/Action.php(145): Action::factory('view', Object(WikiPage), Object(RequestContext))
#12 /usr/local/apache/common-local/php-1.24wmf8/includes/Wiki.php(154): Action::getActionName(Object(RequestContext))
#13 /usr/local/apache/common-local/php-1.24wmf8/includes/Wiki.php(527): MediaWiki->getAction()
#14 /usr/local/apache/common-local/php-1.24wmf8/includes/Wiki.php(452): MediaWiki->main()
#15 /usr/local/apache/common-local/php-1.24wmf8/index.php(46): MediaWiki->run()
#16 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#17 {main}
Comment 1 Gerrit Notification Bot 2014-06-12 20:58:40 UTC
Change 139203 had a related patch set uploaded by Yurik:
JsonConfig ext update, fixing bug 66555

https://gerrit.wikimedia.org/r/139203
Comment 2 Gerrit Notification Bot 2014-06-12 20:59:23 UTC
Change 139204 had a related patch set uploaded by Yurik:
JsonConfig ext update, fixing bug 66555

https://gerrit.wikimedia.org/r/139204
Comment 3 Gerrit Notification Bot 2014-06-12 21:04:19 UTC
Change 139203 merged by jenkins-bot:
JsonConfig ext update, fixing bug 66555

https://gerrit.wikimedia.org/r/139203
Comment 4 Gerrit Notification Bot 2014-06-12 21:05:04 UTC
Change 139204 merged by jenkins-bot:
JsonConfig ext update, fixing bug 66555

https://gerrit.wikimedia.org/r/139204
Comment 5 Andre Klapper 2014-06-13 10:07:24 UTC
Do those merged patches fix the problem, or is more work needed?
Comment 6 Yuri Astrakhan 2014-06-13 15:26:02 UTC
Those patches are really workaround, the core issue remains.
Comment 7 This, that and the other (TTO) 2014-07-19 10:06:56 UTC
Moving to ContentHandler, as that appears to be where the bug lies. If I'm wrong, please don't hesitate to move it back.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links