Last modified: 2014-07-16 11:52:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68557, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66557 - Adding a Wikidata link from Wikipedia and Wikivoyage fails
Adding a Wikidata link from Wikipedia and Wikivoyage fails
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Unprioritized critical with 1 vote (vote)
: ---
Assigned To: Wikidata bugs
https://en.wikipedia.org/wiki/Indiana...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-12 21:18 UTC by Fabimaru
Modified: 2014-07-16 11:52 UTC (History)
6 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
gray fields (80.22 KB, image/jpeg)
2014-06-13 10:36 UTC, JAn Dudík
Details

Description Fabimaru 2014-06-12 21:18:25 UTC
When a Wikipedia or Wikivoyage page does not have a link to another language:
- the user can click on the link "Add links"
- a dialog "Link with page" is displayed
- if the user starts to type a language name, there is an auto-completion

Problem: the auto-completion stopped working recently at least in Wikivoyage and Wikipedia, English and French. When I start to type a language name, nothing happens and in the Firefox Javascript console the message "TypeError: this.options.source is not a function" in the file "/static-1.24wmf8/extensions/Wikidata/extensions/ValueView/lib/jquery.ui/jquery.ui.suggester.js", in the function "_getSuggestions". Call stack:

._getSuggestions(term="e")jquery....ster.js (495 行目)
.search(event=undefined)jquery....ster.js (415 行目)
._create/<(event=Object { originalEvent=Event input, type="eachchange", timeStamp=1402607831917, もっと見る...}, previousValue="en")jquery....ctor.js (50 行目)
$.event.special.eachchange.add/<(event=Object { originalEvent=Event input, type="eachchange", timeStamp=1402607831917, もっと見る...})jquery....ange.js (60 行目)
jQuery.event.dispatch(event=Object { originalEvent=Event input, type="eachchange", timeStamp=1402607831917, もっと見る...})load.ph...190453Z (4641 行目)
jQuery.event.add/elemData.handle(e=input )load.ph...190453Z (4309 行目)


Example of page:
https://en.wikipedia.org/wiki/Indiana_%28singer%29?debug=true

Browser: Firefox 29&30, no specific add-on excepted Firebug
Comment 1 Fabimaru 2014-06-12 21:23:40 UTC
I tried to debug but could not find the reason. From what I understand, the jquery suggester needs to be configured with an "option.source" for the possible items. I cannot understand how is it supposed to be passed in the MediaWiki infrastructure.

Also the problem appeared only when there is no link yet. If there is already one, the link ("edit links") will lead to Wikidata.
Comment 2 Dan 2014-06-12 22:30:36 UTC
I confirm this bug. Tried to add interwiki to enwiki at ro.wiki, and no auto-completion was. This thing happens only last 3-5 hours. Today, about 10 hours, ago i attached succesfuly 2-3 interwiki.
Comment 3 JAn Dudík 2014-06-13 10:36:47 UTC
Created attachment 15646 [details]
gray fields

I confirm with Opera 22 , langs: cs, sk and de
Comment 4 Marius Hoch 2014-06-13 15:15:11 UTC
Fixed with: https://github.com/wmde/ValueView/pull/69, https://gerrit.wikimedia.org/r/139369 and https://gerrit.wikimedia.org/r/139376

We will try to deploy this as soon as possible, but it might take until Monday.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links