Last modified: 2014-07-21 21:22:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68582, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66582 - Track entity redirects in a database table (associated with the wb_entity_per_page table).
Track entity redirects in a database table (associated with the wb_entity_per...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0 s=2014-07-15
:
: 66074 (view as bug list)
Depends on:
Blocks: 67033 66971 66972
  Show dependency tree / graph
 
Reported: 2014-06-13 12:24 UTC by Daniel Kinzler
Modified: 2014-07-21 21:22 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2014-06-13 12:24:11 UTC 
When recording redirects in wb_entity_per_page, we need a column (or separate table) to hold the redirect target. This will also allow us to efficiently identifry and filter redirects when iterating over all entit
Comment 1 Daniel Kinzler 2014-06-13 12:24:27 UTC 
...when iterating over all entity IDs.
Comment 2 Daniel Kinzler 2014-06-16 14:17:55 UTC 
*** Bug 66074 has been marked as a duplicate of this bug. ***
Comment 3 Daniel Kinzler 2014-06-23 10:16:15 UTC 
After some thought, it seems that it's more sensible to have redirect in a separate table, and remove them from wb_entity_per_page. This will assure compatibility with existing code that uses wb_entity_per_page to iterate over all entities, and it generally makes for a nicer database layout.

Adjusting the description accordingly.
Comment 4 Lydia Pintscher 2014-07-01 12:27:57 UTC 
We are not going to track them for now.
Comment 5 Lydia Pintscher 2014-07-01 12:31:07 UTC 
Needed after all.
Comment 6 Daniel Kinzler 2014-07-15 10:33:59 UTC 
After some back-and-forth, we decided to add a column to entity_per_page after all, see the thread on wikidata-tech startwing with <http://lists.wikimedia.org/pipermail/wikidata-tech/2014-July/000540.html>.
Comment 7 Gerrit Notification Bot 2014-07-17 16:24:05 UTC 
Change 147137 had a related patch set uploaded by Daniel Kinzler:
Tests for redirect handling in EntityRevisionLookup

https://gerrit.wikimedia.org/r/147137
Comment 8 Gerrit Notification Bot 2014-07-18 15:35:14 UTC 
Change 147118 merged by jenkins-bot:
Track redirects in EPP table

https://gerrit.wikimedia.org/r/147118
Comment 9 Gerrit Notification Bot 2014-07-21 21:22:29 UTC 
Change 147137 merged by jenkins-bot:
Tests for redirect handling in EntityRevisionLookup

https://gerrit.wikimedia.org/r/147137
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links