Last modified: 2014-07-16 11:58:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68632, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66632 - Exception from line 282 of EntityHandler.php
Exception from line 282 of EntityHandler.php
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest critical (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-15 08:49 UTC by Aude
Modified: 2014-07-16 11:58 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aude 2014-06-15 08:49:01 UTC 
Exception from line 282 of /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/content/EntityHandler.php: Can only construct GlobeCoordinateValue with a string globe parameter

we need to be able to handle such values more gracefully as we did previously.
Comment 1 Aude 2014-06-15 08:49:16 UTC 
it's a blocker
Comment 2 Thiemo Mättig 2014-06-15 11:11:56 UTC 
https://github.com/DataValues/Geo/pull/13
Comment 3 Jeroen De Dauw 2014-06-15 13:12:13 UTC 
Looks like I missed this piece of behaviour when reimplementing the deserialization code in WikibaseInternalSerialization.
Comment 4 Jeroen De Dauw 2014-06-15 13:19:43 UTC 
Apparently we have no tests for this in Wikibase...
Comment 5 Jeroen De Dauw 2014-06-15 13:33:34 UTC 
Should be fixed by https://github.com/wmde/WikibaseInternalSerialization/pull/30

Though I suspect the same oversight will have been made in DataModel Serialization. Will check that
Comment 6 Jeroen De Dauw 2014-06-15 13:55:36 UTC 
Indeed. Now also fixed with https://github.com/wmde/WikibaseDataModelSerialization/pull/66
Comment 7 Jeroen De Dauw 2014-06-16 18:22:53 UTC 
Should now be fixed. Better also merge https://gerrit.wikimedia.org/r/#/c/139878/
Comment 8 Jeroen De Dauw 2014-06-18 12:32:53 UTC 
Aude, can you confirm this is fixed now?
Comment 9 Aude 2014-06-19 09:29:33 UTC 
works for me. thanks!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links