Last modified: 2014-06-16 22:00:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68669, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66669 - [Regression pre-wmf10] Review your changes throws fatal error
[Regression pre-wmf10] Review your changes throws fatal error
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Roan Kattouw
: browser-test-bug
: 66681 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-16 15:01 UTC by Chris McMahon
Modified: 2014-06-16 22:00 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2014-06-16 15:01:08 UTC
On any page at http://en.wikipedia.beta.wmflabs.org/ 

Make an edit

Click Review your changes

User sees a modal dialog saying "Error loading data from server: error."


fatal log shows

[2014-06-16 14:57:25] Fatal error: Call to a member function get() on a non-object at /srv/common-local/php-master/includes/api/ApiQueryRevisions.php on line 629
Server: deployment-apache02
Method: POST
URL: http://en.wikipedia.beta.wmflabs.org/w/api.php
Cookie: enwiki-gettingStartedUserId=kJSYCjZCvJa3o9xl48ODXiGk1DaduG2m; centralnotice_bucket=1-4.2; centralauth_LoggedOut=1402329725; ve-beta-welcome-dialog=1; edittoolscharsubset=0; optin=beta; GeoIP=US:Tucson:32.2217:-110.9265:v4; uls-previous-languages=%5B%22en%22%5D; mediaWiki.user.sessionId=y0AhKxKUggdcyUd7KMOLw6Bx8JuBJTqT; enwikiUserID=54; enwikiUserName=Cmcmahon; enwikiSession=090850308740c4e1214d05399aa6d221; centralauth_User=Cmcmahon; centralauth_Session=d47cf247a4d3ea1081576f3520609ffe
Backtrace:
#0 /srv/common-local/php-master/includes/api/ApiQueryRevisions.php(629): ApiQueryRevisions::extractRowInfo()
#1 /srv/common-local/php-master/includes/api/ApiQueryRevisions.php(402): ApiQueryRevisions->extractRowInfo(Object(stdClass))
#2 /srv/common-local/php-master/includes/api/ApiQuery.php(282): ApiQueryRevisions->execute()
#3 /srv/common-local/php-master/includes/api/ApiMain.php(908): ApiQuery->execute()
#4 /srv/common-local/php-master/includes/api/ApiMain.php(332): ApiMain->executeAction()
#5 /srv/common-local/php-master/extensions/VisualEditor/ApiVisualEditor.php(230): ApiMain->execute()
#6 /srv/common-local/php-master/extensions/VisualEditor/ApiVisualEditor.php(501): ApiVisualEditor->diffWikitext(Object(Title), 'Starting a new ...')
#7 /srv/common-local/php-master/includes/api/ApiMain.php(908): ApiVisualEditor->execute()
#8 /srv/common-local/php-master/includes/api/ApiMain.php(363): ApiMain->executeAction()
#9 /srv/common-local/php-master/includes/api/ApiMain.php(334): ApiMain->executeActionWithErrorHandling()
#10 /srv/common-local/php-master/api.php(85): ApiMain->execute()
#11 /srv/common-local/w/api.php(3): require('/srv/common-loc...')
#12 {main}
[2014-06-16 14:57:25]
Comment 1 Chris McMahon 2014-06-16 15:01:37 UTC
Note: saving changes works correctly
Comment 2 Chris McMahon 2014-06-16 17:56:20 UTC
I am seeing this error modal dialog also intermittently on test2wiki (and presumably mediawiki.org) when switching modes from VE to wikitext editor.
Comment 3 James Forrester 2014-06-16 18:32:32 UTC
*** Bug 66681 has been marked as a duplicate of this bug. ***
Comment 4 Gerrit Notification Bot 2014-06-16 18:32:40 UTC
Change 139879 had a related patch set uploaded by Catrope:
Followup e48ecbc5: fix fatal error due to undefined variable

https://gerrit.wikimedia.org/r/139879
Comment 5 Gerrit Notification Bot 2014-06-16 18:44:58 UTC
Change 139879 merged by jenkins-bot:
Followup e48ecbc5: fix fatal error due to undefined variable

https://gerrit.wikimedia.org/r/139879
Comment 6 Rummana Yasmeen 2014-06-16 21:55:00 UTC
Verified the fix in Betalabs

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links