Last modified: 2014-09-23 03:52:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68701, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66701 - [cxserver] If config.js is not valid JavaScript, throw an error


Summary:	[cxserver] If config.js is not valid JavaScript, throw an error

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	ContentTranslation (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Kartik Mistry

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2014-06-17 08:33:00 UTC

Throw an error instead of falling silently back to default settings. Took us a while to figure out why cxserver was not starting on beta labs.

Comment 1 Santhosh Thottingal 2014-08-25 10:21:48 UTC

Niklas, does this change look like an acceptable fix?https://gerrit.wikimedia.org/r/#/c/155223/3/utils/Conf.js

Comment 2 Niklas Laxström 2014-08-26 10:10:29 UTC

Santhosh: I don't see how it would avoid "falling silently back to default settings".

Comment 3 Gerrit Notification Bot 2014-09-17 09:34:51 UTC

Change 160937 had a related patch set uploaded by KartikMistry:
Log error if config.js is invalid

https://gerrit.wikimedia.org/r/160937

Comment 4 Gerrit Notification Bot 2014-09-17 09:59:40 UTC

Change 160937 merged by jenkins-bot:
Fail if config.js is invalid

https://gerrit.wikimedia.org/r/160937