Last modified: 2014-11-06 11:48:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68715, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66715 - Suggester is case-sensitive but shouldn't
Suggester is case-sensitive but shouldn't
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Normal major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=0
:
Depends on: 72622
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-17 12:48 UTC by Thiemo Mättig
Modified: 2014-11-06 11:48 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Thiemo Mättig 2014-06-17 12:48:26 UTC
This is an issue in the new ("ooMenu" based) suggester.

I can not paste (or type) an exact match and press enter if the only difference is the casing of a single character. The enter key is ignored then. This used to work in the old suggester and is a feature users actually rely on (and already started to complain about, e.g. in IRC).

Same bug in all suggesters (choosing an item, choosing a site link and so on).

Related to bug 66437 but not the same.
Comment 1 Henning 2014-10-28 12:56:29 UTC
First off, this bug seems to be about the entityselector. The suggester itself does not care about letter case. Restoring case insensitivity in the entityselector would be simple. However, after some investigating, here is why the functionality has been removed:
When the entityselector's "selected" event is triggered, the snakview redraws--including the property "column". This involves resetting the property label, thus, overwriting the property label the user entered with the actual property label.
When applying case insensitivity, the following would occur: Imagine properties "abc", "ABCDEF". When the user types "ABC" and the API call querying for suggestions returns, "ABC" is overwritten with "abc" although the user might still want to have "ABCDEF". Yes, it is possible to just continue typing, ending up with "abcDEF" that gets finally replaced with "ABCDEF", but that is quite some clumsy behaviour.
Comment 2 Henning 2014-10-30 16:14:51 UTC
Should directly be fixed along with https://gerrit.wikimedia.org/r/#/c/170064/.
Comment 3 Gerrit Notification Bot 2014-10-31 12:14:57 UTC
Change 170064 had a related patch set uploaded by Tobias Gritschacher:
Applied case-insensitivity to snakview property selector

https://gerrit.wikimedia.org/r/170064
Comment 4 Gerrit Notification Bot 2014-11-06 11:48:57 UTC
Change 170064 merged by Adrian Lang:
Applied case-insensitivity to snakview property selector

https://gerrit.wikimedia.org/r/170064

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links