Last modified: 2014-07-10 13:59:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68724, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66724 - VisualEditor: Template dialog throws error when target is a wikitext expression
VisualEditor: Template dialog throws error when target is a wikitext expression
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-07-10
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-17 15:06 UTC by Carl Fürstenberg
Modified: 2014-07-10 13:59 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Carl Fürstenberg 2014-06-17 15:06:33 UTC
on https://www.mediawiki.org/wiki/Extension:Gadgets and edit throws following error:
TypeError: title is null
https://bits.wikimedia.org/static-1.24wmf9/resources/src/mediawiki/mediawiki.Title.js
Line 123
Comment 1 Ed Sanders 2014-06-18 11:44:45 UTC
Looks like we don't support evaluated template names:
{{ {{TNTN:Extension}}
  |...
}}

Not sure if this a VE or Parsoid problem.
Comment 2 James Forrester 2014-06-19 00:54:39 UTC
(In reply to Ed Sanders from comment #1)
> Looks like we don't support evaluated template names:
> {{ {{TNTN:Extension}}
>   |...
> }}
> 
> Not sure if this a VE or Parsoid problem.

Feels like this template should have been ExpandedAttrs'ed by Parsoid?
Comment 3 Gabriel Wicke 2014-06-19 01:00:52 UTC
Simple test case: {{{{echo|echo}}|foo}}

The Parsoid output looks correct to me.
Comment 4 Gabriel Wicke 2014-06-19 01:05:14 UTC
Hmm, actually there is an issue in the Parsoid output for this test case, but it's not likely to be related to this bug.

{{{{echo|echo}}|foo}}

data-mw looks good, but the string 'foo' is missing in the span for some reason.

<span about="#mwt1" typeof="mw:Transclusion" data-mw='{"parts":[{"template":{"target":{"wt":"{{echo|echo}}"},"params":{"1":{"wt":"foo"}},"i":0}}]}'></span>

Reported in bug 66820.
Comment 5 James Forrester 2014-06-19 01:19:28 UTC
(In reply to Gabriel Wicke from comment #3)
> Simple test case: {{{{echo|echo}}|foo}}
> 
> The Parsoid output looks correct to me.

Thanks!


Ed – I guess in these cases we should just detect that it's an invalid title somehow and mark the template as uneditable?
Comment 6 Florian 2014-07-05 13:14:46 UTC
I wanted to open a new bug, but here is still one :) Actually i become the message:
Uncaught TypeError: Cannot read property 'replace' of null

fyi :)
Comment 7 Krinkle 2014-07-09 19:48:09 UTC
Yep. It used to throw 
> Uncaught TypeError: title is null

It now fails earlier because the code changed. Namely on 

> Uncaught TypeError: Cannot read property 'replace' of null
Comment 8 Gerrit Notification Bot 2014-07-09 20:09:08 UTC
Change 145055 had a related patch set uploaded by Krinkle:
MWTemplatePage: Account for template.title being null

https://gerrit.wikimedia.org/r/145055
Comment 9 Gerrit Notification Bot 2014-07-10 13:59:03 UTC
Change 145055 merged by jenkins-bot:
MWTemplatePage: Account for template.title being null

https://gerrit.wikimedia.org/r/145055

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links