Last modified: 2014-06-27 20:45:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68734, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66734 - VisualEditor: [Regression wmf9] In Firefox, closing the Language Inspector without making any change throws sel.nativeSelection is null


Summary:	VisualEditor: [Regression wmf9] In Firefox, closing the Language Inspector wi...

Status:	VERIFIED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2014-06-19
Assigned To:	Ed Sanders

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-06-17 18:45 UTC by Rummana Yasmeen
Modified:	2014-06-27 20:45 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (115.28 KB, image/png) 2014-06-17 18:45 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-06-17 18:45:22 UTC

Created attachment 15674 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE in Firefox
2.Go to Insert>Language
3.Close the language inspector without making any change

Observed Result:
An error appears in the console:
TypeError: sel.nativeSelection is null

See the screenshot attached

Environment:test2 and Betalabs

Comment 1 Gerrit Notification Bot 2014-06-18 10:02:48 UTC

Change 140326 had a related patch set uploaded by Esanders:
Catch rangy exception thrown in FF

https://gerrit.wikimedia.org/r/140326

Comment 2 Gerrit Notification Bot 2014-06-18 17:59:05 UTC

Change 140326 merged by jenkins-bot:
Catch rangy exception thrown in FF

https://gerrit.wikimedia.org/r/140326

Comment 3 Gerrit Notification Bot 2014-06-18 18:04:38 UTC

Change 140426 had a related patch set uploaded by Catrope:
Catch rangy exception thrown in FF

https://gerrit.wikimedia.org/r/140426

Comment 4 Gerrit Notification Bot 2014-06-18 18:06:56 UTC

Change 140426 merged by jenkins-bot:
Catch rangy exception thrown in FF

https://gerrit.wikimedia.org/r/140426

Comment 5 James Forrester 2014-06-19 17:38:52 UTC

Apparently not. :-(

Comment 6 James Forrester 2014-06-19 18:25:33 UTC

Actually yes, just a deployment issue.

Comment 7 Rummana Yasmeen 2014-06-19 19:02:02 UTC

It's still not working on test2.

Comment 8 James Forrester 2014-06-19 22:13:24 UTC

Indeed, not working. Sigh.

Comment 9 James Forrester 2014-06-19 22:15:38 UTC

Note: doesn't appear in Beta Labs for some reason, but does in production.

Comment 10 Rummana Yasmeen 2014-06-20 00:22:56 UTC

After re-deployment , it is now fixed :)

Comment 11 Rummana Yasmeen 2014-06-20 22:25:56 UTC

Verified the fix in test2

Comment 12 Rummana Yasmeen 2014-06-27 20:45:23 UTC

Verified the fix in production

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links