Last modified: 2014-09-04 21:04:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68743, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66743 - Preview step of "firstedit" tour is displaying incorrectly after save


Summary:	Preview step of "firstedit" tour is displaying incorrectly after save

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	GuidedTour (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Matthew Flaschen

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-06-17 21:20 UTC by Steven Walling
Modified:	2014-09-04 21:04 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Beta Labs screenshot (1.01 MB, image/png) 2014-06-17 21:20 UTC, Steven Walling	Details
enwiki screenshot (1.45 MB, image/png) 2014-07-07 17:37 UTC, Steven Walling	Details
English Wikipedia screenshot (362.92 KB, image/png) 2014-08-28 20:40 UTC, Steven Walling	Details
Add an attachment (proposed patch, testcase, etc.)

Description Steven Walling 2014-06-17 21:20:34 UTC

Created attachment 15677 [details]
Beta Labs screenshot

Steps to reproduce:

1. Go to an article on Beta Labs with the firstedit tour enabled, like http://en.wikipedia.beta.wmflabs.org/wiki/Corgi?tour=firstedit

2. Edit and save the page without previewing 

3. You should see the preview instructions again, unattached

Comment 1 Steven Walling 2014-06-17 21:21:58 UTC

This does not appear to happen with the Save step.

Comment 2 Steven Walling 2014-06-17 21:28:58 UTC

Also tested on English Wikipedia proper, and I do not get this.

Comment 3 Gerrit Notification Bot 2014-07-02 08:59:32 UTC

Change 143170 had a related patch set uploaded by Robmoen:
Add automatic next button step specification.

https://gerrit.wikimedia.org/r/143170

Comment 4 Rob Moen 2014-07-07 16:59:36 UTC

(In reply to Gerrit Notification Bot from comment #3)
> Change 143170 had a related patch set uploaded by Robmoen:
> Add automatic next button step specification.
> 
> https://gerrit.wikimedia.org/r/143170

This patch was mistakenly marked with the bug and is unrelated.

Comment 5 Steven Walling 2014-07-07 17:37:32 UTC

Created attachment 15856 [details]
enwiki screenshot

Comment 6 Steven Walling 2014-07-07 18:18:53 UTC

This is now appearing in production on enwiki. 

You can replicate by:

1. viewing a page with either ?tour=firstedit or the GettingStarted CTA, and then choosing "Edit this page"
2. click Edit
3. Go back to read mode

Comment 7 Gerrit Notification Bot 2014-07-10 23:23:22 UTC

Change 145464 had a related patch set uploaded by Robmoen:
End tour if saving before preview

https://gerrit.wikimedia.org/r/145464

Comment 8 Gerrit Notification Bot 2014-07-14 18:31:14 UTC

Change 145464 merged by jenkins-bot:
End tour if saving before preview

https://gerrit.wikimedia.org/r/145464

Comment 9 Steven Walling 2014-08-28 20:40:42 UTC

Created attachment 16305 [details]
English Wikipedia screenshot

Comment 10 Steven Walling 2014-08-28 20:43:12 UTC

This same issue is happening on production for the gettingstartedtasktoolbar tour. See new screenshot.

Comment 11 Matthew Flaschen 2014-09-04 21:04:04 UTC

Please file a new bug against the GettingStarted extension.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links