Last modified: 2014-10-10 01:20:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68812, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66812 - Backport mediawiki.skinning.content.parsoid to MW 1.23.x so VisualEditor master can run there
Backport mediawiki.skinning.content.parsoid to MW 1.23.x so VisualEditor mast...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.23.0
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-18 20:18 UTC by James Forrester
Modified: 2014-10-10 01:20 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
mah: Backport_to_Stable?


Attachments

Description James Forrester 2014-06-18 20:18:47 UTC
In advance of rewriting the skins system, MediaWiki 1.24 introduces a mediawiki.skinning.content.parsoid module which is a dependency of VisualEditor master.

Making it so that downstream users can use newer versions of VisualEditor but not bleeding-edge MediaWiki would be a nice improvement for them, especially for LTS versions.

However, we may want to have it settle down a bit more until now?
Comment 1 Kunal Mehta (Legoktm) 2014-08-20 19:41:19 UTC
Is this still the only thing blocking VE master on 1.23? Or have there been new breaking things since then?
Comment 2 James Forrester 2014-08-20 20:23:45 UTC
(In reply to Kunal Mehta (Legoktm) from comment #1)
> Is this still the only thing blocking VE master on 1.23? Or have there been
> new breaking things since then?

Lots of new breaking things since then, like your patches to make VE use Config, but VE-not-quite-master from a month ago or so probably would be able to go if this stuff was backported to MW REL1_23 (and more importantly, users wouldn't need to install the very confusing Parsoid PHP extension in addition to the Parsoid nodejs service).
Comment 3 Andre Klapper 2014-10-08 11:50:48 UTC
Which specific, identified commits are proposed as backport candidates here?
Comment 4 James Forrester 2014-10-09 18:52:39 UTC
(In reply to Andre Klapper from comment #3)
> Which specific, identified commits are proposed as backport candidates here?

`git log --oneline resources/src/mediawiki.skinning/content.parsoid.less`:

4ae23e7 Fix Parsoid's span.reference styling to match PHP's output
5ada680 Remove Parsoid-specific padding and background
244e1fc Apply bidi styles to references in Parsoid styles
76a5ea6 Minor: Remove unnecessary @noflip annotation
9573eb2 Add unfloated thumb styling in Parsoid CSS
56300b6 Align image frame padding with core
4f69ebe Tweaks to Parsoid CSS styles for citations.
6f45ac4 Fix rendering of centered caption-less images
26a39ec Hide the caption of frameless or inline images in Parsoid HTML
4fe80f6 Minor: more specific parsoid image styling with child selectors
a3525f0 Bug 51245: Add auto-numbered link CSS to Parsoid styles
a6c074a Minor clarification & tweak for Parsoid render testing
7086dad Bug 66287: Proper caption styling
99f093a Make sure images that don't have an explicit alignment get aligned right
e826298 Add border and background styling to the Parsoid styles for images
295b2dc Followup dd1c7f7fd7: fix LESSification errors in Parsoid styles
dd1c7f7 Create a version of mediawiki.skinning.content for Parsoid HTML

There are probably more to come, but this is good enough. Given that 1.23 is LTS, I imagine Mark wants to support VE on it? Confused why he just rejected the backport he requested…
Comment 5 Mark A. Hershberger 2014-10-10 01:20:45 UTC
(In reply to James Forrester from comment #4)
> There are probably more to come, but this is good enough. Given that 1.23 is
> LTS, I imagine Mark wants to support VE on it? Confused why he just rejected
> the backport he requested…

I was going through the backport request queue and didn't see anything to backport.

Replacing the flag and, hopefully, I'll have time later to go through the list of patches.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links