Last modified: 2014-06-20 17:44:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68820, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66820 - Broken template expansion on {{{{echo|echo}}|foo}}
Broken template expansion on {{{{echo|echo}}|foo}}
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-19 01:04 UTC by Gabriel Wicke
Modified: 2014-06-20 17:44 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2014-06-19 01:04:41 UTC
{{{{echo|echo}}|foo}}

data-mw looks good, but the string 'foo' is missing in the span for some reason.

<span about="#mwt1" typeof="mw:Transclusion" data-mw='{"parts":[{"template":{"target":{"wt":"{{echo|echo}}"},"params":{"1":{"wt":"foo"}},"i":0}}]}'></span>
Comment 1 Gabriel Wicke 2014-06-19 01:12:25 UTC
This seems to be specific to using the wt2html form, for example at http://parsoid-lb.eqiad.wikimedia.org/_wikitext/. Using parse.js or retrieving an existing page at http://parsoid-lb.eqiad.wikimedia.org/mediawikiwiki/User%3AGWicke%2FTest%2Ftpl?oldid=1040353 works fine.

The other difference is span wrapping in the broken version vs. p wrapping in the working one.
Comment 2 Arlo Breault 2014-06-19 23:22:28 UTC
What's happening here is that we clear the default page name when using that form without specifying a page name (I guess to avoid Main_Page showing up the meta headers in the output) but during the parse, template fetches return invalidtitle. I guess we should remove that and always parse in the context of a page.
Comment 3 Gerrit Notification Bot 2014-06-19 23:24:59 UTC
Change 140865 had a related patch set uploaded by Arlolra:
Always parse in the context of a page

https://gerrit.wikimedia.org/r/140865
Comment 4 Gerrit Notification Bot 2014-06-20 17:42:29 UTC
Change 140865 merged by jenkins-bot:
Only set title on preprocessor requests if present

https://gerrit.wikimedia.org/r/140865

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links