Last modified: 2014-07-17 19:36:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68863, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66863 - VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images
VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping th...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-07-10
Assigned To: Moriel Schottlender
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-19 23:51 UTC by Rummana Yasmeen
Modified: 2014-07-17 19:36 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-06-19 23:51:53 UTC 
Steps to reproduce:


1.Open a page with VE
2.Insert an image
3.Open the Media Settings dialog for the image
4.Go to Advanced Settings tab
5.Click on "Make full size"

Observed Result:
It switches to the Custom tab and keeps the size value as default instead of making it full size.

Environment:Betalabs,test2, en.wiki
Comment 1 Gerrit Notification Bot 2014-06-26 00:44:28 UTC 
Change 142171 had a related patch set uploaded by Mooeypoo:
Correctly update full size in MediaSizeWidget

https://gerrit.wikimedia.org/r/142171
Comment 2 Gerrit Notification Bot 2014-06-26 01:17:46 UTC 
Change 142171 merged by jenkins-bot:
Correctly update full size in MediaSizeWidget

https://gerrit.wikimedia.org/r/142171
Comment 3 Rummana Yasmeen 2014-06-27 21:01:43 UTC 
Verified the fix in betalabs
Comment 4 Rummana Yasmeen 2014-06-27 21:06:03 UTC 
We need to backport the fix for this one,it did not make it to test2.
Comment 5 Gerrit Notification Bot 2014-06-29 00:23:16 UTC 
Change 142855 had a related patch set uploaded by Jforrester:
Update VisualEditor to Iba4e6b32

https://gerrit.wikimedia.org/r/142855
Comment 6 Gerrit Notification Bot 2014-06-30 15:31:42 UTC 
Change 142855 merged by jenkins-bot:
Update VisualEditor to Iba4e6b32

https://gerrit.wikimedia.org/r/142855
Comment 7 James Forrester 2014-06-30 16:01:47 UTC 
Backported to wmf11 and working great.
Comment 8 Rummana Yasmeen 2014-06-30 18:27:59 UTC 
Verified the fix on test2
Comment 9 Rummana Yasmeen 2014-07-07 20:28:58 UTC 
Its changing the size value in the dialog but after clicking on "Apply Changes" button it is not making it full size.So, reopening it .
Comment 10 Gerrit Notification Bot 2014-07-08 05:42:10 UTC 
Change 144637 had a related patch set uploaded by Mooeypoo:
Apply 'original size' to images

https://gerrit.wikimedia.org/r/144637
Comment 11 Gerrit Notification Bot 2014-07-08 05:45:15 UTC 
Change 144638 had a related patch set uploaded by Mooeypoo:
Apply 'original size' to images and enable apply button in ve-MW

https://gerrit.wikimedia.org/r/144638
Comment 12 Gerrit Notification Bot 2014-07-08 17:55:20 UTC 
Change 144638 merged by jenkins-bot:
Apply 'original size' to images and enable apply button in ve-MW

https://gerrit.wikimedia.org/r/144638
Comment 13 Gerrit Notification Bot 2014-07-08 17:55:32 UTC 
Change 144637 merged by jenkins-bot:
Apply 'original size' to images

https://gerrit.wikimedia.org/r/144637
Comment 14 Rummana Yasmeen 2014-07-09 00:21:01 UTC 
Verified the fix in Betalabs
Comment 15 Rummana Yasmeen 2014-07-10 23:56:48 UTC 
Verified the fix in test2
Comment 16 Rummana Yasmeen 2014-07-17 19:36:19 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links