Last modified: 2014-11-12 18:46:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68876, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66876 - Flow does not integrate with watchlist "changed since my last visit" highlighting
Flow does not integrate with watchlist "changed since my last visit" highligh...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-20 13:28 UTC by Brad Jorsch
Modified: 2014-11-12 18:46 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot (369.58 KB, image/png)
2014-08-14 22:51 UTC, Quiddity
Details

Description Brad Jorsch 2014-06-20 13:28:27 UTC
MediaWiki applies CSS classes to the individual rows in the watchlist to indicate whether the user has actually viewed that change (e.g. visited the page and seen a revision including the change). These classes are somewhat-unintuitively named "mw-changeslist-line-watched" for unviewed changes and "mw-changeslist-line-not-watched" for viewed changes.

Flow topic changes included in the watchlist are always using the "mw-changeslist-line-not-watched" class, even when the topic has not been viewed.
Comment 1 Quiddity 2014-08-14 22:51:15 UTC
Created attachment 16201 [details]
screenshot

Except for the few pages that I've visited, all the primary links (topic/page names) in the screenshot should be bold (that's the default style applied at mediawiki.org).


Logged in trello as https://trello.com/c/t0abHqXZ/
Comment 2 Jon 2014-09-09 16:43:56 UTC
How Flow activity in history is surfaced  has somewhat changed
I'm not sure what the correct behaviour is now.

I'm guessing what needs to happen is when you view a Flow board, it updates any existing history entries relating to that page so they use the mw-changeslist-line-watched class?
Comment 3 Gerrit Notification Bot 2014-09-09 21:12:32 UTC
Change 159395 had a related patch set uploaded by EBernhardson:
Move EmailNotification watchlist handling into helper methods

https://gerrit.wikimedia.org/r/159395
Comment 4 Gerrit Notification Bot 2014-09-09 21:22:42 UTC
Change 159400 had a related patch set uploaded by EBernhardson:
Update wl_notificationtimestamp when updating Flow page

https://gerrit.wikimedia.org/r/159400
Comment 5 Gerrit Notification Bot 2014-09-12 18:55:22 UTC
Change 159399 had a related patch set uploaded by EBernhardson:
Give RC/Watchlist titles the mw-title html class

https://gerrit.wikimedia.org/r/159399
Comment 6 Gerrit Notification Bot 2014-09-12 20:41:28 UTC
Change 159399 merged by jenkins-bot:
Give RC/Watchlist titles the mw-title html class

https://gerrit.wikimedia.org/r/159399
Comment 7 Gerrit Notification Bot 2014-09-18 18:08:26 UTC
Change 159395 merged by jenkins-bot:
Move EmailNotification watchlist handling into helper method

https://gerrit.wikimedia.org/r/159395
Comment 8 Gerrit Notification Bot 2014-09-18 18:13:17 UTC
Change 159400 merged by jenkins-bot:
Update wl_notificationtimestamp when updating Flow page

https://gerrit.wikimedia.org/r/159400
Comment 9 Andre Klapper 2014-11-12 15:14:03 UTC
All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links