Last modified: 2014-08-20 00:45:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68889, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66889 - Fatal error: undefined method `save' due to outdated plugin
Fatal error: undefined method `save' due to outdated plugin
Status: RESOLVED FIXED
Product: MediaWiki-Vagrant
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Ori Livneh
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-20 20:19 UTC by Bryan Davis
Modified: 2014-08-20 00:45 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bryan Davis 2014-06-20 20:19:58 UTC
$ vagrant status                                                 [264/9172]
Your git/Gerrit username has not been set.
 * If you want anonymous git access, enter 'anonymous'.
 * If you do NOT want vagrant to manage your git remotes while provisioning, hit
 Enter
 * You can always change it later by editing .settings.yaml file
 * If VM has already been created and you enter a value, run 'vagrant provision'
 to update remote git URLs.
 ==> bd808
There was an error loading a Vagrantfile. The file being loaded
and the error message are shown below. This is usually caused by
a syntax error.

Path: /Users/bd808/projects/wmf/vagrant/Vagrantfile
Message: undefined method `save' for #<Settings:0x00000104276b68 @settings={"git
_user"=>"bd808"}>


It turns out that this was caused by Id5938b55093afde571dd67e4e93d5ca98379d5f3 which added a new method to the settings class. I'm running Vagrant 1.6.3 and had version 0.0.2 of the custom MediaWiki-Vagrant plugin installed. Bumping the version number in lib/mediawiki-vagrant/version.rb to 0.0.3 and reinstalling the plugin fixed the crash.

It looks like we may need to come up with a procedure for incrementing the plugin version and notifying the user when their installed plugin is out of date. It would probably also be nice to add feature guards in the Vagrant file for things that need a specific minimum version of the plugin.
Comment 1 Yuri Astrakhan 2014-06-23 20:03:24 UTC
I added a patch Icf3ba214440304145560e2e78ed7149085aeca7c that also bumps the version number. Should there be any other text instructions/actions that are needed to resolve this? I am running on a Vagrant for Windows 1.5.3, will update shortly to try it out.
Comment 2 Bryan Davis 2014-08-20 00:45:40 UTC
Fixed long ago.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links