Last modified: 2014-07-03 01:25:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68893, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66893 - VisualEditor: mw.Title invocations for template titles should use template namespace as default namespace
VisualEditor: mw.Title invocations for template titles should use template na...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-06-26
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-21 00:26 UTC by Roan Kattouw
Modified: 2014-07-03 01:25 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-06-21 00:26:41 UTC
Right now we have things like mw.Title.newFromText( template ); , while really that should use something like mw.Title.newFromText( template, 10 ); or whatever. This is probably fine in practice, but theoretically matters is NS_MAIN and NS_TEMPLATE have different capitalization settings.

We also currently render the titles of {{foo}} (which points to Template:Foo, renders as Foo) and {{:foo}} (which points to Foo, also renders as Foo) the same, we should fix that.
Comment 1 Gerrit Notification Bot 2014-06-21 01:29:22 UTC
Change 141082 had a related patch set uploaded by Jforrester:
Normalize titles in template descriptions in context menu

https://gerrit.wikimedia.org/r/141082
Comment 2 Gerrit Notification Bot 2014-06-25 21:10:37 UTC
Change 141082 merged by jenkins-bot:
Normalize titles in template descriptions in context menu

https://gerrit.wikimedia.org/r/141082
Comment 3 Roan Kattouw 2014-07-03 01:18:01 UTC
(In reply to Roan Kattouw from comment #0)
> Right now we have things like mw.Title.newFromText( template ); , while
> really that should use something like mw.Title.newFromText( template, 10 );
> or whatever. This is probably fine in practice, but theoretically matters is
> NS_MAIN and NS_TEMPLATE have different capitalization settings.
> 
This is not fixed yet, reopening.

> We also currently render the titles of {{foo}} (which points to
> Template:Foo, renders as Foo) and {{:foo}} (which points to Foo, also
> renders as Foo) the same, we should fix that.
This was indeed fixed by https://gerrit.wikimedia.org/r/141082
Comment 4 Gerrit Notification Bot 2014-07-03 01:20:04 UTC
Change 143685 had a related patch set uploaded by Catrope:
Try some more to handle template namespace properly

https://gerrit.wikimedia.org/r/143685
Comment 5 Gerrit Notification Bot 2014-07-03 01:23:51 UTC
Change 143685 merged by jenkins-bot:
Try some more to handle template namespace properly

https://gerrit.wikimedia.org/r/143685
Comment 6 Roan Kattouw 2014-07-03 01:25:02 UTC
(In reply to Roan Kattouw from comment #3)
> (In reply to Roan Kattouw from comment #0)
> > Right now we have things like mw.Title.newFromText( template ); , while
> > really that should use something like mw.Title.newFromText( template, 10 );
> > or whatever. This is probably fine in practice, but theoretically matters is
> > NS_MAIN and NS_TEMPLATE have different capitalization settings.
> > 
> This is not fixed yet, reopening.
> 
Somewhat to my surprise this is in fact fully fixed in https://gerrit.wikimedia.org/r/143685

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links