Last modified: 2014-08-04 14:38:56 UTC
Wikimetrics started to use a custom redis configuration [1] to overcome persistence issues. The point was made [2] that this custom configuration was not needed. So if it's possible, let's switch back to redis' default configuration. [1] https://git.wikimedia.org/commit/operations%2Fpuppet.git/05220a35917f64d43288cc1c891d89cd5f078dfb [2] During code-review of an unrelated change; see line 193 of https://gerrit.wikimedia.org/r/#/c/139558/6/manifests/role/wikimetrics.pp
Change 141116 had a related patch set uploaded by QChris: Parametrize redis' dbfilename https://gerrit.wikimedia.org/r/141116
Change 141120 had a related patch set uploaded by QChris: Have Wikimetrics use the redis module's configuration again https://gerrit.wikimedia.org/r/141120
I disagree, the custom configuration for redis solves other persistence issues. The settings in our custom configuration ensure that Wikimetrics saves more often, which is useful in case of crashes. It also ensures that it fails loudly when writing to file is not possible, which happened in the past and caused a lot of data loss because redis failed silently.
I think that having our own config is useful too. On the CR I was just making the point that TTLs for persistence of celery reports in redis are actually handled via celery, not redis (we just realized this recently)
(In reply to Dan Andreescu from comment #3) > the custom configuration for redis solves other persistence > issues. Yup. That's why I explicitly called them out on change 141120's commit message :-) As it now seems we want to keep them, and since they differ by only two settings, I'll try adding knobs for them in wmf's redis module. That way, we can use our custom settings, and still get the benefit of Ops maintaining the redis module.
If that can be done that would be the best solution, christian.
Change 141116 merged by Ottomata: Parametrize redis' settings needed for Wikimetrics https://gerrit.wikimedia.org/r/141116
Change 141918 had a related patch set uploaded by QChris: Take advantage of redis module again https://gerrit.wikimedia.org/r/141918
Change 141918 abandoned by QChris: Take advantage of redis module again Reason: Doing it in Idecc81b2e052ed5d777a321141f60336ba8ae26b only. https://gerrit.wikimedia.org/r/141918
Change 141120 merged by Ottomata: Have Wikimetrics use the redis module's configuration again https://gerrit.wikimedia.org/r/141120
