Last modified: 2014-06-24 09:10:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68922, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 66922 - Installer can put html errors at the top of LocalSettings.php
Installer can put html errors at the top of LocalSettings.php
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: 1.24.0 release
Assigned To: Mark A. Hershberger
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-21 18:17 UTC by Mark A. Hershberger
Modified: 2014-06-24 09:10 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
mah: Backport_to_Stable+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mark A. Hershberger 2014-06-21 18:17:19 UTC 
https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Notice:_Undefined_index:_createaccount_in_C:%5Cwamp%5Cwww%5Cwiki%5Cincludes%5Cinstaller%5CLocalSettingsGenerator.php_on_line_225

Problems like this would be avoided if it weren't possible for the installer to mix error output in with LocalSettings.php
Comment 1 Gerrit Notification Bot 2014-06-21 18:37:56 UTC 
Change 141261 had a related patch set uploaded by MarkAHershberger:
Don't allow some E_NOTICE messages to end up in the LocalSettings.php

https://gerrit.wikimedia.org/r/141261
Comment 2 Gerrit Notification Bot 2014-06-22 17:58:53 UTC 
Change 141307 had a related patch set uploaded by MarkAHershberger:
Don't allow some E_NOTICE messages to end up in the LocalSettings.php

https://gerrit.wikimedia.org/r/141307
Comment 3 Gerrit Notification Bot 2014-06-23 19:18:13 UTC 
Change 141307 merged by jenkins-bot:
Don't allow some E_NOTICE messages to end up in the LocalSettings.php

https://gerrit.wikimedia.org/r/141307
Comment 4 Gerrit Notification Bot 2014-06-23 20:53:32 UTC 
Change 141261 merged by jenkins-bot:
Don't allow some E_NOTICE messages to end up in the LocalSettings.php

https://gerrit.wikimedia.org/r/141261
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links